Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix semaphore unguarding #41263

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix semaphore unguarding #41263

merged 2 commits into from
Nov 3, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 3, 2023

Apparently sem_get returns a SysvSemaphore class and not a resource anymore. See https://www.php.net/manual/en/function.sem-get.php

@szaimen
fix semaphore guarding
531f5d1 
Signed-off-by: Simon L <[email protected]>
@szaimen szaimen added bug 3. to review Waiting for reviews high labels Nov 3, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone Nov 3, 2023
@szaimen szaimen requested review from st3iny, juliusknorr, kesselb, a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team November 3, 2023 10:48
@szaimen szaimen changed the title fix semaphore guarding fix semaphore unguarding Nov 3, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Nov 3, 2023

/backport to stable27

@szaimen
Copy link
Contributor Author

szaimen commented Nov 3, 2023

/backport to stable26

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 3, 2023
View reviewed changes
lib/private/Preview/Generator.php Fixed Show resolved Hide resolved
@szaimen
address review
b681cf7 
Signed-off-by: Simon L <[email protected]>
@szaimen szaimen enabled auto-merge November 3, 2023 15:19
@szaimen szaimen requested a review from solracsf November 3, 2023 15:34
solracsf
solracsf approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@szaimen szaimen disabled auto-merge November 3, 2023 15:46
@szaimen
Copy link
Contributor Author

szaimen commented Nov 3, 2023

CI failure unrelated

ChristophWurst
ChristophWurst approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

@szaimen szaimen merged commit 86e9fca into master Nov 3, 2023
49 of 50 checks passed
@szaimen szaimen deleted the enh/noid/fix-semaphore-guarding branch November 3, 2023 15:46
@szaimen
Copy link
Contributor Author

szaimen commented Nov 3, 2023

Please squash

Sorry, saw it too late

@ChristophWurst
Copy link
Member

Noted

@szaimen
Copy link
Contributor Author

szaimen commented Nov 3, 2023

/backport to stable27

@szaimen
Copy link
Contributor Author

szaimen commented Nov 3, 2023

/backport to stable26

@szaimen
Copy link
Contributor Author

szaimen commented Nov 3, 2023

The backport bot is dead again 😭

This was referenced Nov 5, 2023
Merged
Merged
@szaimen
Copy link
Contributor Author

szaimen commented Nov 5, 2023

@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@szaimen szaimen mentioned this pull request Nov 8, 2023
Closed
8 tasks
@szaimen szaimen mentioned this pull request Jan 5, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solracsf solracsf solracsf approved these changes

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug high
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@szaimen @ChristophWurst @kesselb @solracsf