Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logic for getting the watcher for a shared external storage #40363

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

icewind1991
Copy link
Member

with the new-ish lazy mount loading the underlying mount might not be loaded yet, so ask the mount cache instead

To test

  • Setup an instance with user A and user B
  • mount external storage M for user A
  • have user A share M with B
  • modify the data in M directly (bypassing NC)
  • as B check if the file listing is updated

with the new-ish lazy mount loading the underlying mount might not be loaded yet, so ask the mount cache instead

Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 11, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Sep 11, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, nfebe and sorbaugh and removed request for a team September 11, 2023 13:02
@icewind1991 icewind1991 requested a review from come-nc September 20, 2023 08:37
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(did not test)

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish feature: filesystem feature: external storage and removed 3. to review Waiting for reviews feature: filesystem labels Feb 23, 2024
@skjnldsv skjnldsv enabled auto-merge February 23, 2024 20:53

This comment has been minimized.

@skjnldsv skjnldsv merged commit ef8cf53 into master Feb 24, 2024
159 checks passed
@skjnldsv skjnldsv deleted the share-external-watcher branch February 24, 2024 11:38
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: external storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants