Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: skip processing for empty response #40234

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 4, 2023

Summary

Skip the further processing if nothing to do.

TODO

  • CI

Checklist

@kesselb kesselb added 3. to review Waiting for reviews performance 🚀 labels Sep 4, 2023
@kesselb kesselb self-assigned this Sep 4, 2023
lib/private/Http/Client/DnsPinMiddleware.php Outdated Show resolved Hide resolved
@kesselb kesselb force-pushed the enh/noid/skip-processing-for-empty-response branch from ee3bae1 to 03f1f1e Compare September 4, 2023 13:28
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@kesselb kesselb merged commit b92f5cd into master Sep 4, 2023
39 checks passed
@kesselb kesselb deleted the enh/noid/skip-processing-for-empty-response branch September 4, 2023 14:41
@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable27

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable26

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable25

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable24

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable23

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable22

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable24
git pull origin stable24

# Create the new backport branch
git checkout -b fix/foo-stable24

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable24

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable23
git pull origin stable23

# Create the new backport branch
git checkout -b fix/foo-stable23

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable23

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable22
git pull origin stable22

# Create the new backport branch
git checkout -b fix/foo-stable22

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable22

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable27

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable26

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable25

@kesselb
Copy link
Contributor Author

kesselb commented Sep 4, 2023

/backport to stable24

@kesselb
Copy link
Contributor Author

kesselb commented Sep 5, 2023

/backport to stable23

@kesselb
Copy link
Contributor Author

kesselb commented Sep 5, 2023

/backport to stable22

plegay added a commit to GIP-RECIA/nextcloud-plugins that referenced this pull request Nov 27, 2023
plegay added a commit to GIP-RECIA/nextcloud-plugins that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants