-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor encryption app commands #39692
Refactor encryption app commands #39692
Conversation
1553fcb
to
4507123
Compare
4507123
to
1b009e2
Compare
Conflicts resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, rebase this against latest master.
1b009e2
to
881123f
Compare
Done. But it has already got out-of-dated. Should I rebase it again? |
@fsamapoor thanks, all good! I was hoping CI might get green if you rebase but no, it's fine. Just wait for other reviews. |
881123f
to
ab2caed
Compare
@fenn-cs Cypress workflows are failing on almost all of my PRs. I don't know if there is anything that I can do to fix them. |
@fsamapoor Not to worry, those failures are unrelated (most likely as they are UI tests). |
ab2caed
to
37bf803
Compare
Conflicts resolved. |
Thank you, please rebase. |
37bf803
to
a45dd55
Compare
Done. |
@fsamapoor now that this has another approval kindly, update/rebase it with master I would put my eyes on the jobs to get it in asap. Thank you! |
a45dd55
to
68da42a
Compare
Sure. Thank you! Other than Cypress workflows, I think there will be no issues. |
To improve code readability. Signed-off-by: Faraz Samapoor <[email protected]>
To improve code readability. Signed-off-by: Faraz Samapoor <[email protected]>
7899057
to
6b795da
Compare
Summary
I have made some adjustments to the
apps/encryption/lib/Command
classes to improve the code readability.The improvements in this PR include but are not limited to:
Checklist