Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dbtableprefix to sample config #38321

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

pulsejet
Copy link
Member

Unfortunately (and naturally), people copy values from the sample config and end up with databases with no prefix. This causes issues for Doctrine in certain corner cases (related pulsejet/memories#648).

So this is a simple proposal to set the sample config value to the default value.

@pulsejet pulsejet added the 3. to review Waiting for reviews label May 16, 2023
@szaimen szaimen requested a review from nickvergessen May 16, 2023 19:30
@szaimen szaimen added this to the Nextcloud 27 milestone May 16, 2023
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, but as far as I'm aware none of the installation options allow setting it anymore, so it should always be oc_
It was removed for the same reason you outlined, it can break without a prefix in certain corner cases.

@szaimen
Copy link
Contributor

szaimen commented May 16, 2023

CI failure unrelated

@szaimen szaimen merged commit 0b14443 into master May 16, 2023
@szaimen szaimen deleted the pulsejet/patch-dbtableprefix branch May 16, 2023 20:50
@blizzz blizzz mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants