Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust file custom picker component padding #38256

Merged
merged 2 commits into from
May 15, 2023

Conversation

julien-nc
Copy link
Member

Because the smart picker does not have padding anymore.

…not have padding anymore

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc added the 3. to review Waiting for reviews label May 15, 2023
@julien-nc julien-nc added this to the Nextcloud 27 milestone May 15, 2023
@julien-nc julien-nc requested a review from juliusknorr May 15, 2023 10:10
@julien-nc
Copy link
Member Author

/backport to stable26

@julien-nc
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr requested review from a team, susnux, nfebe and szaimen and removed request for a team May 15, 2023 18:55
@juliusknorr juliusknorr added bug design Design, UI, UX, etc. labels May 15, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux susnux merged commit 864aa1b into master May 15, 2023
@susnux susnux deleted the fix/noid/file-smart-picker-padding branch May 15, 2023 21:27
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@blizzz blizzz mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants