Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable pull-down-to-refresh for mobile #38225

Merged
merged 1 commit into from
May 16, 2023
Merged

disable pull-down-to-refresh for mobile #38225

merged 1 commit into from
May 16, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 12, 2023 •
edited
Loading

Disable pull-down-to-refresh for mobile since this sometimes causes unintended refreshs on mobile when scrolling up.

The solution is based on https://thewebdev.info/2021/10/09/how-to-prevent-pull-down-to-refresh-in-mobile-chrome/

@szaimen szaimen added enhancement design Design, UI, UX, etc. 2. developing Work in progress labels May 12, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 12, 2023
@szaimen szaimen force-pushed the enh/noid/disable-pull-to-refresh branch from 234b004 to 8c76abf Compare May 12, 2023 15:16
@szaimen szaimen marked this pull request as ready for review May 12, 2023 17:54
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 12, 2023
@szaimen szaimen requested review from jancborchardt, nimishavijay, a team, susnux, nfebe and Pytal and removed request for a team May 12, 2023 17:55
@szaimen szaimen modified the milestones: Nextcloud 28, Nextcloud 27 May 12, 2023
jancborchardt
jancborchardt approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

Just to clarify as I was a bit confused initially, this disables the browser native refresh, not anything from Nextcloud. (Which Firefox mobile also has since a recent update.)

@szaimen
Copy link
Contributor Author

szaimen commented May 15, 2023

/rebase

@nextcloud-command nextcloud-command force-pushed the enh/noid/disable-pull-to-refresh branch from 8c76abf to 296b2ef Compare May 15, 2023 16:50
@szaimen
Copy link
Contributor Author

szaimen commented May 15, 2023

/compile amend /

@szaimen szaimen enabled auto-merge May 15, 2023 17:03
@szaimen @nextcloud-command
disable pull-down-to-refresh for mobile
3974fec 
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the enh/noid/disable-pull-to-refresh branch from 296b2ef to 3974fec Compare May 15, 2023 20:09
@szaimen szaimen merged commit be7c9ce into master May 16, 2023
@szaimen szaimen deleted the enh/noid/disable-pull-to-refresh branch May 16, 2023 00:50
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@nextcloud nextcloud locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@susnux susnux susnux approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
🖍 Design team
Archived in project
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
4 participants
@szaimen @jancborchardt @susnux @miaulalala