Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the color-primary-element* variables #38223

Merged
merged 1 commit into from
May 13, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 12, 2023

Explanation: the color-primary variables are not to be used in components because the introduce problems with high-contrast primary colors. Fix this by using the primary-element variables instead.

@szaimen szaimen added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels May 12, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 12, 2023
@szaimen szaimen requested review from susnux, juliusknorr, skjnldsv, Pytal and a team May 12, 2023 13:44
@nextcloud-command nextcloud-command force-pushed the enh/noid/use-primary-element-variables branch from d99f9de to d49fd7c Compare May 12, 2023 15:17
@szaimen
Copy link
Contributor Author

szaimen commented May 13, 2023

/rebase

@nextcloud-command nextcloud-command force-pushed the enh/noid/use-primary-element-variables branch from d49fd7c to 251cfe6 Compare May 13, 2023 08:30
@szaimen
Copy link
Contributor Author

szaimen commented May 13, 2023

/compile amend /

@szaimen szaimen enabled auto-merge May 13, 2023 08:31
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the enh/noid/use-primary-element-variables branch from 251cfe6 to f5e8268 Compare May 13, 2023 10:15
@szaimen
Copy link
Contributor Author

szaimen commented May 13, 2023

Integration-contacts-menu failure unrelated

@szaimen szaimen disabled auto-merge May 13, 2023 11:10
@szaimen szaimen merged commit 7ba6323 into master May 13, 2023
@szaimen szaimen deleted the enh/noid/use-primary-element-variables branch May 13, 2023 11:10
@szaimen szaimen modified the milestones: Nextcloud 28, Nextcloud 27 May 13, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants