Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add css variables for info colors (--color-info) #38205

Merged
merged 1 commit into from
May 16, 2023
Merged

Add css variables for info colors (--color-info) #38205

merged 1 commit into from
May 16, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 11, 2023 •
edited
Loading

Summary

Introduce a new css variable to style the color of information text / boxes in a consistent color across Nextcloud apps.

Checklist

@susnux susnux requested review from jancborchardt and skjnldsv May 11, 2023 14:58
@susnux susnux mentioned this pull request May 11, 2023
Merged
@susnux susnux added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels May 11, 2023
@susnux susnux requested a review from mejo- May 11, 2023 15:00
jancborchardt
jancborchardt approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @susnux!

@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 11, 2023
@szaimen szaimen added this to the Nextcloud 28 milestone May 11, 2023
@mejo- mejo- mentioned this pull request May 12, 2023
Closed
mejo-
mejo- approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this.

@susnux susnux force-pushed the feat/css-add-info-color branch from b094a91 to 9726438 Compare May 12, 2023 12:51
@szaimen
Copy link
Contributor

szaimen commented May 16, 2023

/rebase

@szaimen szaimen enabled auto-merge May 16, 2023 09:31
@nextcloud-command nextcloud-command force-pushed the feat/css-add-info-color branch from 9726438 to 4f9472a Compare May 16, 2023 09:31
@szaimen
Copy link
Contributor

szaimen commented May 16, 2023

CI failure is unrelated afaics

@szaimen szaimen disabled auto-merge May 16, 2023 13:13
@szaimen szaimen merged commit 75b7c13 into master May 16, 2023
@szaimen szaimen deleted the feat/css-add-info-color branch May 16, 2023 13:13
@szaimen szaimen modified the milestones: Nextcloud 28, Nextcloud 27 May 16, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@szaimen szaimen mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@mejo- mejo- mejo- approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@susnux @szaimen @jancborchardt @mejo- @skjnldsv