Get rid of more int casts in file size manipulations #38196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On 32bits sizes may be floats. There were a few places where this was still not taken into account.
I did not fix the following:
Because it would bubble up to the interface
IObjectStoreMultiPartUpload
in OCP, and I’m not sure if it is possible/easy to support floats there.Also did not fix:
It’s not clear if those can overflow or not.
Checklist