[stable26] fix(workflowengine): Fix multiple UI issues in workflow engine admin settings #38189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
Antreesy,
juliusknorr and
nickvergessen
…settings Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
backport/38170/stable26
branch
from
6966026 to
bac0941
Compare
nickvergessen
requested review from
a team,
susnux and
nfebe
and removed request for
a team
nickvergessen
approved these changes
May 16, 2023
susnux
reviewed
May 16, 2023
| :placeholder="t('workflowengine', 'Select a filter')" | ||
| @input="updateCheck" /> | ||
| <NcMultiselect v-model="currentOperator" | ||
| <NcSelect v-model="currentOperator" | ||
| :disabled="!currentOption" | ||
| :options="operators" | ||
| class="comparator" | ||
| label="name" | ||
| track-by="operator" |
There was a problem hiding this comment.
There is no track-by for NcSelect or vue-select.
There was a problem hiding this comment.
Yeah, right. That's an oversight in master:
https://github.com/nextcloud/server/pull/38170/files#diff-89faeece31f41549ed11dd7b8c99eb2b830f068e75ab525526f8ed49a95688cbR7
Will send a new PR to master and backport it
susnux
approved these changes
May 16, 2023
Merged
|
/backport to stable25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #38170