-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dav): Run system address book create-if-not-exists in transaction #37965
Conversation
} | ||
$this->atomic(function() use ($addressBookId, $cardUri, $vCard) { | ||
$existingCard = $this->backend->getCard($addressBookId, $cardUri); | ||
if ($existingCard === false) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
$this->backend->deleteCard($addressBookId, $cardId); | ||
$this->atomic(function() use ($addressBookId, $cardId, $user) { | ||
$card = $this->backend->getCard($addressBookId, $cardId); | ||
if ($card === false) { |
Check notice
Code scanning / Psalm
DocblockTypeContradiction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't really like injecting IDBConnection
here, but the alternative is catching UniqueConstraintViolationException
for each insertion and do the update afterwards, which doesn't suit me much more.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
c37c76b
to
e866a95
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Christoph Wurst <[email protected]>
e866a95
to
2cc672d
Compare
CI failure unrelated |
Summary
@CarlSchwan Jun 24, 2022
TODO
Checklist