From 112d516f27a0cb752e464d103dda0ba324983e3e Mon Sep 17 00:00:00 2001 From: Simon L Date: Sun, 5 Feb 2023 16:44:27 +0100 Subject: [PATCH] imaginary - allow to generate heif, pdf and svg thumbnails Signed-off-by: Simon L --- lib/private/Preview/Imaginary.php | 63 ++++++++++++++++++++++--------- 1 file changed, 45 insertions(+), 18 deletions(-) diff --git a/lib/private/Preview/Imaginary.php b/lib/private/Preview/Imaginary.php index 0d75dbd70695f..5d559b65f0009 100644 --- a/lib/private/Preview/Imaginary.php +++ b/lib/private/Preview/Imaginary.php @@ -57,7 +57,7 @@ public function getMimeType(): string { } public static function supportedMimeTypes(): string { - return '/image\/(bmp|x-bitmap|png|jpeg|gif|heic|svg|tiff|webp)/'; + return '/(image\/(bmp|x-bitmap|png|jpeg|gif|heic|heif|svg\+xml|tiff|webp)|application\/(pdf|illustrator))/'; } public function getCroppedThumbnail(File $file, int $maxX, int $maxY, bool $crop): ?IImage { @@ -81,33 +81,60 @@ public function getCroppedThumbnail(File $file, int $maxX, int $maxY, bool $crop $httpClient = $this->service->newClient(); + $convert = false; + switch ($file->getMimeType()) { case 'image/gif': case 'image/png': $mimeType = 'png'; break; + case 'image/svg+xml': + case 'application/pdf': + case 'application/illustrator': + $convert = true; + break; default: $mimeType = 'jpeg'; } - $quality = $this->config->getAppValue('preview', 'jpeg_quality', '80'); - - $operations = [ - [ - 'operation' => 'autorotate', - ], - [ - 'operation' => ($crop ? 'smartcrop' : 'fit'), - 'params' => [ - 'width' => $maxX, - 'height' => $maxY, - 'stripmeta' => 'true', - 'type' => $mimeType, - 'norotation' => 'true', - 'quality' => $quality, + if ($convert) { + $operations = [ + [ + 'operation' => 'convert', + 'params' => [ + 'type' => 'png', + ] + ], + [ + 'operation' => ($crop ? 'smartcrop' : 'fit'), + 'params' => [ + 'width' => $maxX, + 'height' => $maxY, + 'type' => 'png', + 'norotation' => 'true', + ] ] - ] - ]; + ]; + } else { + $quality = $this->config->getAppValue('preview', 'jpeg_quality', '80'); + + $operations = [ + [ + 'operation' => 'autorotate', + ], + [ + 'operation' => ($crop ? 'smartcrop' : 'fit'), + 'params' => [ + 'width' => $maxX, + 'height' => $maxY, + 'stripmeta' => 'true', + 'type' => $mimeType, + 'norotation' => 'true', + 'quality' => $quality, + ] + ] + ]; + } try { $response = $httpClient->post(