feat(dav): Add VTIMEZONE data when creating personal calendar #36522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The personal calendar created at the user's first login does not hold a timezone property. This leads to reminders being sent using server time instead of the user's timezone, since the calendar has no tz information. See nextcloud/calendar#4778 for extra context. The vtimezone ICS data comes from the @nextcloud/calendar-js library, https://github.com/nextcloud/calendar-js/tree/main/resources/timezones, which uses a python script to generate the vtimezone files from the data produced by https://github.com/libical/vzic (which in turn uses data from IANA's tzdata). A few months ago, Mozilla switched to using https://hg.mozilla.org/comm-central/rev/2b430305eaf46970d62e9569e1800d5c4be9071c ICU4C directly (see icu::VTimeZone::createVTimeZoneByID), and seems to produce data dynamically instead (with a cache). This allows them to avoid manual intervention to refresh data, and they say it also includes more valid timezones. See https://bugzilla.mozilla.org/show_bug.cgi?id=1794029 In any case, we need a proper way to update the timezone database regularly (this data is already 4 years old). Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
added
3. to review
tcitworld
requested review from
ChristophWurst,
st3iny,
kesselb,
miaulalala and
a team
tcitworld
requested review from
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
miaulalala
approved these changes
Feb 6, 2023
tcitworld
added
2. developing
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
skjnldsv
deleted the
add-vtimezone-data-when-creating-personal-calendar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The personal calendar created at the user's first login does not hold a timezone property. This leads to reminders being sent using server time instead of the user's timezone, since the calendar has no tz information.
See nextcloud/calendar#4778 for extra context.
The vtimezone ICS data comes from the @nextcloud/calendar-js library, https://github.com/nextcloud/calendar-js/tree/main/resources/timezones, which uses a python script to generate the vtimezone files from the data produced by https://github.com/libical/vzic (which in turn uses data from IANA's tzdata).
A few months ago, Mozilla switched to using
https://hg.mozilla.org/comm-central/rev/2b430305eaf46970d62e9569e1800d5c4be9071c ICU4C directly (see icu::VTimeZone::createVTimeZoneByID), and seems to produce data dynamically instead (with a cache). This allows them to avoid manual intervention to refresh data, and they say it also includes more valid timezones. See https://bugzilla.mozilla.org/show_bug.cgi?id=1794029
In any case, we need a proper way to update the timezone database regularly (this data is already 4 years old).
TODO
createCalendarChecklist