Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rdparty/symfony/translation #36505

Closed
wants to merge 2 commits into from
Closed

Conversation

vitormattos
Copy link
Contributor

Bump symfony/translation

Ref: nextcloud/3rdparty#1304
Close nextcloud/3rdparty#922

The original PR from dependabot used an old version of translation package. I created a new PR with the newest version of package compatible with PHP 8.0.

The class TranslatorInterface that I removed from comment was removed from Translation package.

@vitormattos vitormattos self-assigned this Feb 2, 2023
@vitormattos vitormattos added this to the Nextcloud 27 milestone Feb 2, 2023
@vitormattos vitormattos added dependencies php Pull requests that update Php code labels Feb 2, 2023
@nickvergessen
Copy link
Member

Feature freeze, try again when stable 26 is branched off end of the month 😅

@come-nc
Copy link
Contributor

come-nc commented Mar 21, 2023

Please rebase @vitormattos

@vitormattos vitormattos force-pushed the 3rdparty/symfony/translation branch from 08ca3b6 to 54ab0c3 Compare March 22, 2023 12:35
@vitormattos
Copy link
Contributor Author

@come-nc rebased.

@vitormattos vitormattos force-pushed the 3rdparty/symfony/translation branch from 54ab0c3 to 324490c Compare March 22, 2023 14:14
lib/private/L10N/L10NString.php Outdated Show resolved Hide resolved
lib/private/L10N/L10NString.php Outdated Show resolved Hide resolved
Was changed at the newest version of symfony/translation

Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos force-pushed the 3rdparty/symfony/translation branch from 324490c to 09eea2a Compare March 23, 2023 09:12
This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@nickvergessen
Copy link
Member

Replaced by nextcloud/3rdparty#1482

@skjnldsv skjnldsv deleted the 3rdparty/symfony/translation branch March 14, 2024 07:49
@skjnldsv skjnldsv removed this from the Nextcloud 28 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants