Catch missing non-optional controller parameter #35599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing controller parameters cause an unhandled TypeError that results in a generic HTTP500. By reflecting on the params more clever we can determine if a parameter can be filled by its default value or if the request is invalid. A missing parameter in a JSON request, for example, could now be answered by a HTTP422 – unprocessible entity. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added
pending documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…arameter Signed-off-by: Christoph Wurst <[email protected]>
…arameter Signed-off-by: Christoph Wurst <[email protected]>
…arameter Signed-off-by: Christoph Wurst <[email protected]>
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
ChristophWurst
added
0. Needs triage
skjnldsv
added
2. developing
Merged
This was referenced Mar 14, 2024
Merged
Merged
Merged
skjnldsv
deleted the
chore/catch-missing-non-optional-controller-parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: n/a
Summary
Missing controller parameters cause an unhandled TypeError that results in a generic HTTP500. By reflecting on the params more clever we can determine if a parameter can be filled by its default value or if the request is invalid. A missing parameter in a JSON request, for example, could now be answered by a HTTP422 – unprocessible entity.
Before
After
TODO
Checklist