Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new getcachebuster functioin also for webmanifest #35263

Closed
wants to merge 2 commits into from

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 18, 2022

Signed-off-by: Simon L [email protected]

@szaimen szaimen added the 2. developing Work in progress label Nov 18, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Nov 18, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Nov 18, 2022

Seems like

'theme_color' => $this->themingDefaults->getColorPrimary(),
'background_color' => $this->themingDefaults->getColorPrimary(),
returns in some cases still the default color since the usersession is not given... Need to think how to retreive that properly...

* @return Http\JSONResponse
*/
public function getManifest($app) {
$cacheBusterValue = $this->config->getAppValue('theming', 'cachebuster', '0');
$this->util = new Util($this->config, $this->appManager, $this->appData, $this->imageManager);

Check failure

Code scanning / Psalm

UndefinedThisPropertyAssignment

Instance property OCA\Theming\Controller\ThemingController::$util is not defined
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 31 milestone Aug 14, 2024
@szaimen szaimen deleted the enh/noid/getcachebuster-in-webmanifest branch August 14, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants