Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache storage id mapping in memcache #31905

Closed
wants to merge 3 commits into from
Closed

cache storage id mapping in memcache #31905

wants to merge 3 commits into from

Conversation

icewind1991
Copy link
Member

Saves a query for every storage that is being used

@icewind1991 icewind1991 requested review from a team, PVince81, juliusknorr and skjnldsv and removed request for a team April 8, 2022 14:25
@icewind1991 icewind1991 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 8, 2022
juliusknorr
juliusknorr reviewed Apr 8, 2022
View reviewed changes
lib/private/Files/Cache/StorageGlobal.php
public function clearCache() {
$this->cache = [];
$this->memCache->clear();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be something to check where this is being called, clearing redis with a prefix might be a bit slow due to the keys command having a O(n) runtime.

@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

/rebase

@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

Apparently tests need fixing...

@szaimen szaimen disabled auto-merge April 17, 2023 19:46
This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Feb 27, 2024
This was referenced Mar 12, 2024
Merged
Merged
@skjnldsv
Copy link
Member 

1) OCA\Files_External\Tests\Storage\WebdavTest::testCheckUpdate
Trying to access array offset on value of type null

/home/runner/work/server/server/lib/private/Files/Cache/StorageGlobal.php:84
/home/runner/work/server/server/lib/private/Files/Cache/Storage.php:102
/home/runner/work/server/server/lib/private/Files/Cache/Storage.php:81

@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 15, 2024
@skjnldsv skjnldsv marked this pull request as draft March 15, 2024 12:08
This was referenced Mar 18, 2024
Merged
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr left review comments

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
2. developing Work in progress performance 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@icewind1991 @szaimen @skjnldsv @juliusknorr @CarlSchwan @blizzz