Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add event to allow apps to overwrite user quota #22910

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman [email protected]

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 17, 2020
@icewind1991 icewind1991 added this to the Nextcloud 20 milestone Sep 17, 2020
@icewind1991 icewind1991 force-pushed the user-quota-event branch 3 times, most recently from a1db6b6 to e47ad96 Compare September 17, 2020 13:59
@faily-bot
Copy link

faily-bot bot commented Sep 17, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33162: failure

checkers

Show full log
The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

mariadb10.4-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #35 ('folder', 3, 11)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

mysql8.0-php7.2

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Comments\ManagerTest::testGetForObjectSince with data set #2 (null, 'desc', 20, 0, 4)
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
     0 => 5
-    1 => 0
+    1 => 4
     2 => 3
     3 => 2
     4 => 1
 )

/drone/src/tests/lib/Comments/ManagerTest.php:383

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let me dump the autoloader for this as well.

Signed-off-by: Morris Jobke <[email protected]>
@MorrisJobke MorrisJobke merged commit 7fcb754 into master Sep 17, 2020
@MorrisJobke MorrisJobke deleted the user-quota-event branch September 17, 2020 16:14
@MorrisJobke MorrisJobke mentioned this pull request Sep 17, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants