Emit event on status-change #22801
Merged
Emit event on status-change #22801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgehrke
requested review from
rullzer,
nickvergessen,
ChristophWurst and
juliusknorr
| await setStatus(statusType) | ||
| commit('setStatus', { statusType }) | ||
| emit('user_status:status.updated', { |
There was a problem hiding this comment.
if we add the user, we could use the same event for other user status-updates as well?
There was a problem hiding this comment.
Sounds reasonable, let me add that
There was a problem hiding this comment.
@ChristophWurst you approved this event name?
There was a problem hiding this comment.
what is the issue? the .?
ChristophWurst
approved these changes
Sep 11, 2020
nickvergessen
approved these changes
Sep 14, 2020
Signed-off-by: Georg Ehrke <[email protected]>
rullzer
force-pushed
the
bugfix/noid/status_event_bus
branch
from
4ea165c to
f4d4975
Compare
This was referenced Sep 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.