Add multiple files to favorites

[MariusBluem]

See proposed mockup:

• Nextcloud 13

[weeman1337]

I'll take this one.

[weeman1337]

I think this isn't as trivial as I thought in the beginning. It's more than just adding the action:

If the user selects only non-favorites: Action "Add to favorites" ✓

If the user selects only favorites: Action: "Remove from favorites" ✓

If the user select favorites and non-favorites?

• Should we display both actions "Add to favorites" and "Remove from favorites"? That means if there are already some favorites and the user selects "add" the files simply keep their favorite status.
• Not display the actions.

[MorrisJobke]

Most likely nothing for 14 -> moving to 15.

[MorrisJobke]

@weeman1337 You still can continue to think about this and work on this, but it will then be integrated into 15 first.

[tobiasKaminsky]

Once this is in, we should also do this on client-side

[MorrisJobke]

Once this is in, we should also do this on client-side

You can already do this. It only needs a client side implementation. For multiple files/folder moves we trigger just multiple MOVE requests from the frontend, which allows proper UI feedback as well. The favorites already can be tagged via the PROPPATCH method. The only problem here is that the activity is not yet implemented. See #26393

[tobiasKaminsky]

So there will be no new endpoint to pass bunch of file so mark them as favorited?

[MorrisJobke]

So there will be no new endpoint to pass bunch of file so mark them as favorited?

Correct - only multiple PROPPATCH requests.

[szaimen]

@weeman1337 Any update here?

[ghost]

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

[tobiasKaminsky]

Still a valid enhancement, no idea why bot closed this.

[tobiasKaminsky]

@skjnldsv is there a specific new API to bulk add files to favorite, or is it "just" doing it one by one?

[skjnldsv]

For now one-by-one.

If I start adding dedicated APIs, I will ping the client team, I'll keep that in mind, no worries :)

server/apps/files/src/actions/favoriteAction.ts

Lines 99 to 102 in 0411cc6

	async execBatch(nodes: Node[], view: Navigation) {
	const willFavorite = shouldFavorite(nodes)
	return Promise.all(nodes.map(async node => await favoriteNode(node, view, willFavorite)))
	},