Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites in '...' menu looks wrong #7520

Closed
schiessle opened this issue Dec 14, 2017 · 6 comments
Closed

Favorites in '...' menu looks wrong #7520

schiessle opened this issue Dec 14, 2017 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files papercut Annoying recurring issue with possibly simple fix. stale Ticket or PR with no recent activity

Comments

@schiessle
Copy link
Member

schiessle commented Dec 14, 2017

Feel free to close this issue, if you think this was already discussed enough. I didn't saw any discussion about it so far, so I want to rise my concerns.

With Nextcloud 13 we moved favorites to the '...' menu. This is how it looks:

favorites

Two thinks which confuses me the first time I saw it:

  1. Why is it the only item with a color icon? This looks strange. I would suggest to use a monochrome icon like for all other actions as well

  2. Why is it at the top? I don't think that this is the operation you want to do most of the time you open the menu. I think "Details" should continue to stay at the top.

cc @nextcloud/designers @jancborchardt

@schiessle schiessle added design Design, UI, UX, etc. feature: files labels Dec 14, 2017
@schiessle schiessle added this to the Nextcloud 13 milestone Dec 14, 2017
@skjnldsv
Copy link
Member

Agree with both.

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Dec 14, 2017
@jancborchardt
Copy link
Member

I'm ok with moving it to the second position, after details.

The coloring was added to better discern the entries. Favorites have a clear color-coding, and I'm thinking of doing the same for Delete (dark red). In a list of 6 actions (possibly more depending which app injects stuff) this really helps do things quickly, and makes the interface more helpful & less bland.

@MariusBluem
Copy link
Member

#7379

@jancborchardt
Copy link
Member

@MariusBluem what's your point though? :) It's separate suggestions?

@rullzer rullzer added the papercut Annoying recurring issue with possibly simple fix. label Jan 9, 2018
@rullzer rullzer removed this from the Nextcloud 13 milestone Jan 9, 2018
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@skjnldsv
Copy link
Member

Can we take a position here, it's an easy fix and will lower our issues count :)

@jancborchardt
Copy link
Member

We had this for some time now and as favoriting is not used so often it’s really good in the menu as compared to outside. Also allows us to have the exact same menu entries in the right-click menu → Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files papercut Annoying recurring issue with possibly simple fix. stale Ticket or PR with no recent activity
Projects
None yet
Development

No branches or pull requests

7 participants