Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favourite should not show spinner in preview #4845

Closed
MorrisJobke opened this issue May 12, 2017 · 1 comment
Closed

Add favourite should not show spinner in preview #4845

MorrisJobke opened this issue May 12, 2017 · 1 comment
Labels
design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 13

Comments

@MorrisJobke
Copy link
Member

  • from Nextcloud 12 overview #2672
  • remove spinner on file icon by default (maybe show it when the request takes longer than 1 second – but then definitely do not show it in place of the filetype icon)

cc @nextcloud/javascript
@MorrisJobke MorrisJobke added design Design, UI, UX, etc. enhancement feature: files papercut Annoying recurring issue with possibly simple fix. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels May 12, 2017
@nickvergessen nickvergessen mentioned this issue May 12, 2017
Closed
59 tasks
@jancborchardt jancborchardt added this to the Nextcloud 13 milestone May 23, 2017
@jancborchardt
Copy link
Member

This is fixed with the move to a small icon for favorites only by @danxuliu :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 13
Development

No branches or pull requests
2 participants
@MorrisJobke @jancborchardt