Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File list footer is to far away from the list #46860

Closed
juliusknorr opened this issue Jul 30, 2024 · 0 comments · Fixed by #47500
Closed

File list footer is to far away from the list #46860

juliusknorr opened this issue Jul 30, 2024 · 0 comments · Fixed by #47500
Labels
3. to review Waiting for reviews 30-feedback bug

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Jul 30, 2024 •
edited
Loading

The file list footer is too far off if some header is shown in the file list (e.g. folder description or recommended files):

Screenshot 2024-07-30 at 08 29 33

This seems to be caused by:

server/apps/files/src/components/VirtualList.vue

Line 219 in 968d412

minHeight: `${this.totalRowCount * this.itemHeight + this.beforeHeight}px`,

@susnux It seems adding the beforeHeight is the problematic part but I cannot tell if that was needed for the scroll behaviour in 75dcf90
@juliusknorr juliusknorr added bug 1. to develop Accepted and waiting to be taken care of labels Jul 30, 2024
@juliusknorr juliusknorr moved this to 👓 Design review in 🖍 Design team Jul 30, 2024
@elzody elzody mentioned this issue Aug 26, 2024
Merged
4 tasks
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Aug 27, 2024
@github-project-automation github-project-automation bot moved this from 👓 Design review to 🎉 Done in 🖍 Design team Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews 30-feedback bug
Projects
🖍 Design team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(files): fix list gap at bottom nextcloud/server
3 participants
@juliusknorr @skjnldsv @szaimen