Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Uploading large file to public deposit folder should not show "done" when the file is being processed #42770

Closed
6 of 8 tasks
RphCos opened this issue Jan 15, 2024 · 0 comments · Fixed by #45652
Closed
6 of 8 tasks
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug feature: files
Milestone

Comments

@RphCos
Copy link

RphCos commented Jan 15, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Hey all, quick QOL fix and I believe quick win although not very critical :

When uploading large files to a public deposit link the progress bar will show that the file is done uploading while it is actually being processed. It does warns the user if he tries to close the tab/window while it's going, but with no explanation why.

This is confusing and error prone when using this feature, especially given that this usecase is most likely used with people the ITD can't reach to explain the behavior

Upload in progress :
image
Upload is actually being processed but shows as "complete" on the progress bar
image
You need to instruct the users to wait to have this output to leave the page
image

If the user goes through with closing the tab/window while his download is being processed it will raise a SabreDAV Bad Request error

Steps to reproduce

  1. Having a Nextcloud properly configured to handle large files otherwise you'll run in other issues irrelevant to this one.
  2. Create folder
  3. Setup public sharing link with Deposit Files permissions
  4. Upload large files (at least > 2Go)

Expected behavior

There should be a step between this step

Capture d'écran 2024-01-15 084041
and this step

Capture d'écran 2024-01-15 084326

With a loading icon, indicating that the file is being processed.
This does work when you upload large file and are logged in.

Installation method

Community Manual installation with Archive

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Enabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "tempdirectory": "\/data\/tmp\/",
        "dbtype": "mysql",
        "version": "27.1.5.1",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "forwarded_for_headers": [
            "HTTP_X_FORWARDED_FOR"
        ],
        "overwritehost": "***REMOVED SENSITIVE VALUE***",
        "overwriteprotocol": "https",
        "overwriteconaddr": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "theme": "",
        "loglevel": 1,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "filelocking.enabled": true,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 0
        },
        "mail_smtpmode": "smtp",
        "mail_smtpsecure": "ssl",
        "mail_sendmailmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpauth": 1,
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "default_language": "fr",
        "default_locale": "fr_FR",
        "simpleSignUpLink.shown": false,
        "app_install_overwrite": [
            "whiteboard"
        ],
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}

List of activated Apps

{
    "apps": {
        "app:list": []
    }
}

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

Following error only arise if the user goes through with leaving the page while the large file is being processed. It is misleading as the same errors happen in case of a wrong timeout configuration



{"reqId":"mXw4oKTAYqt2WRa3lSzv","level":3,"time":"2024-01-13T19:12:14+00:00","remoteAddr":"***REMOVED SENSITIVE VALUE***","user":"--","app":"no app in context","method":"PUT","url":"/public.php/webdav/***REMOVED SENSITIVE VALUE***","message":"Taille du fichier attendue : 2854565342 octets mais taille du fichier lue (depuis le client Nextcloud) et écrit (dans le stockage Nextcloud) : 1124556800 octets. Cela peut être un problème de réseau au niveau du client ou un problème de stockage au niveau du serveur.","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0","version":"27.1.5.1","exception":{"Exception":"Sabre\\DAV\\Exception\\BadRequest","Message":"Taille du fichier attendue : 2854565342 octets mais taille du fichier lue (depuis le client Nextcloud) et écrit (dans le stockage Nextcloud) : 1124556800 octets. Cela peut être un problème de réseau au niveau du client ou un problème de stockage au niveau du serveur.","Code":0,"Trace":[{"file":"/var/www/nextcloud/apps/dav/lib/Connector/Sabre/Directory.php","line":149,"function":"put","class":"OCA\\DAV\\Connector\\Sabre\\File","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":1098,"function":"createFile","class":"OCA\\DAV\\Connector\\Sabre\\Directory","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php","line":504,"function":"createFile","class":"Sabre\\DAV\\Server","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php","line":89,"function":"httpPut","class":"Sabre\\DAV\\CorePlugin","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":472,"function":"emit","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":253,"function":"invokeMethod","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php","line":321,"function":"start","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/apps/dav/appinfo/v1/publicwebdav.php","line":123,"function":"exec","class":"Sabre\\DAV\\Server","type":"->"},{"file":"/var/www/nextcloud/public.php","line":81,"args":["/var/www/nextcloud/apps/dav/appinfo/v1/publicwebdav.php"],"function":"require_once"}],"File":"/var/www/nextcloud/apps/dav/lib/Connector/Sabre/File.php","Line":297,"message":"Taille du fichier attendue : 2854565342 octets mais taille du fichier lue (depuis le client Nextcloud) et écrit (dans le stockage Nextcloud) : 1124556800 octets. Cela peut être un problème de réseau au niveau du client ou un problème de stockage au niveau du serveur.","exception":[],"CustomMessage":"Taille du fichier attendue : 2854565342 octets mais taille du fichier lue (depuis le client Nextcloud) et écrit (dans le stockage Nextcloud) : 1124556800 octets. Cela peut être un problème de réseau au niveau du client ou un problème de stockage au niveau du serveur."},"id":"65a4e5eda64c0"}

Additional info

No response

@RphCos RphCos added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 15, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug feature: files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants