Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar "mark as favorite" menu item mixed up the menu text #41711

Closed
AndyScherzinger opened this issue Nov 23, 2023 · 2 comments · Fixed by #41719 or #41733
Closed

Sidebar "mark as favorite" menu item mixed up the menu text #41711

AndyScherzinger opened this issue Nov 23, 2023 · 2 comments · Fixed by #41719 or #41733
Assignees
@marcoambrosini
Labels
2. developing Work in progress 28-feedback bug regression
Milestone
Nextcloud 28

Comments

@AndyScherzinger
Copy link
Member

favorite state no-favorite state
2023-11-24 00_38_32 2023-11-24 00_38_47

From my pov the icons in the menu reflect the result of the action while the text reflects the current state instead of the state when hitting the menu item.

What do you think @marcoambrosini ?
@AndyScherzinger AndyScherzinger added bug 1. to develop Accepted and waiting to be taken care of 0. Needs triage Pending check for reproducibility or if it fits our roadmap regression 28-feedback labels Nov 23, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Nov 23, 2023
@AndyScherzinger AndyScherzinger changed the title Sidebar "mark as favorite" menu item mixewd up the menu text Sidebar "mark as favorite" menu item mixed up the menu text Nov 23, 2023
@marcoambrosini
Copy link
Member

I agree @AndyScherzinger, I did it like that because that's how it's done files list menu. It seemed strange to me, but I didn't raise that. I'm going to change both then :)

@marcoambrosini marcoambrosini self-assigned this Nov 24, 2023
@marcoambrosini marcoambrosini mentioned this issue Nov 24, 2023
Merged
5 tasks
@marcoambrosini
Copy link
Member

Sidebar is fixed, but I'm unable to fix the bug in the files list @skjnldsv could you help me out?

@AndyScherzinger AndyScherzinger added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap 1. to develop Accepted and waiting to be taken care of labels Nov 24, 2023
@AndyScherzinger AndyScherzinger mentioned this issue Nov 24, 2023
Merged
@AndyScherzinger AndyScherzinger linked a pull request Nov 24, 2023 that will close this issue
[stable28] Fix action button labels #41733
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoambrosini marcoambrosini

Labels
2. developing Work in progress 28-feedback bug regression
Projects
🖍 Design team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging a pull request may close this issue.

Fix action button labels nextcloud/server
[stable28] Fix action button labels nextcloud/server
2 participants
@AndyScherzinger @marcoambrosini