Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioning inexistent user has strange feedback #4105

Closed
jancborchardt opened this issue Mar 27, 2017 · 4 comments
Closed

Mentioning inexistent user has strange feedback #4105

jancborchardt opened this issue Mar 27, 2017 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: comments
Milestone

Comments

@jancborchardt
Copy link
Member

Right now when you mention an inexistent user, your comment looks like this:

capture du 2017-03-27 22-58-56

It’s a bit much. Instead we should just go for simply this so you can actually see your typo and maybe edit:
capture du 2017-03-27 22-59-44

Also, we should directly catch it on entry. Like if you typed in @blabla and that person does not exist, on click of the submit button show a tooltip saying @blabla does not exist. Maybe even with a suggestion afterwards like Did you mean @blablub?

@blizzz @nextcloud/javascript

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: comments labels Mar 27, 2017
@jancborchardt jancborchardt added this to the Nextcloud 13 milestone Mar 27, 2017
@blizzz
Copy link
Member

blizzz commented Jul 4, 2017

@jancborchardt the username should not be end user visible. blablub might be nice to some degree, however it does not help you to see "Heyo @f9590888-8f3f-4549-a796-15e9de8a4da7", instead this feels more like a bug.

@jancborchardt
Copy link
Member Author

Well the case I mentioned is more for when you @mention someone you can remember the name of, but make a typo (like blizz with 2 z ;)
Your case is some LDAP ID or so which would only appear with autocompletion anyway, so of course there the username would be shown.

@blizzz
Copy link
Member

blizzz commented Jul 6, 2017

OK, so you're case is about mistyping. Honestly, I think it is an OK form of signaling, that something is wrong with the username. You still can edit the comment and fix it. It would work with having the @blabla being not formatted in bold, perhaps, however I am not really convinced it makes a difference.

Agreed, you won't type in a UUID. Now, however, user deletions enters the stage. The admin removes a user, and you'll have the same issue eventually.

@jancborchardt
Copy link
Member Author

Ok, closing this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: comments
Projects
None yet
Development

No branches or pull requests

2 participants