Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: Not possible to navigate the tabs in sidebar #39415

Closed
4 of 8 tasks
JuliaKirschenheuter opened this issue Jul 17, 2023 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#4406 or nextcloud-libraries/nextcloud-vue#4501
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug

Comments

@JuliaKirschenheuter
Copy link
Contributor

⚠️ This issue respects the following points: ⚠️

Bug description

It have to be possible to navigate through all tabs with keyboard arrows. For now it is only possible to navigate to to the first neighbor tab on the left or the right side and then focus goes to the photos slider and navigation goes only through images, not on tabs as it should.

Steps to reproduce

  1. Go to files view
  2. Open any image and click to "open sidebar"
  3. Go to the tabs navigation (activity, comments, sharing)
  4. Try to navigate with keyboard arrows

Expected behavior

It is possible to navigate with keyboard arrows

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@JuliaKirschenheuter JuliaKirschenheuter added bug 1. to develop Accepted and waiting to be taken care of labels Jul 17, 2023
@szaimen
Copy link
Contributor

szaimen commented Jul 17, 2023

Cc @nextcloud/server-frontend

@ShGKme
Copy link
Contributor

ShGKme commented Aug 8, 2023

Additional info:

Keyboard navigation in tabs themself works and follows https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html . It works in files without viewer.

But it doesn't work in files opened in Viewer because NcModal intercepts arrow navigation.

I think, we can check current focus element in NcModal and handle arrow navigation, only then the focus is inside modal.

@ShGKme
Copy link
Contributor

ShGKme commented Sep 5, 2023

Arrow navigation is fixed, but there is still a problem with ESC, e.g. from open select or picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug
Projects
None yet
3 participants