New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions tab shows broken image for empty files #37067

Closed

Tracked by

juliusknorr opened this issue Mar 7, 2023 · 0 comments · Fixed by #38467

Closed

Tracked by

Versions tab shows broken image for empty files #37067

juliusknorr opened this issue Mar 7, 2023 · 0 comments · Fixed by #38467

Assignees

Labels

1. to develop 26-feedback bug

Member

juliusknorr commented Mar 7, 2023

When a version file is empty or the preview could not be generated it currently loads a 404 image which some browsers render as a broken preview:

Best would be to have a fallback image for empty files or if the onerror handler for the image tag triggers.

cc @artonge since you worked on the vue rewrite if i remember correctly

juliusknorr added bug 1. to develop 26-feedback labels

artonge self-assigned this

This was referenced May 24, 2023

Files versions feedback #38431

Open

Add fallback when a there is no preview for a version #38467

Merged

artonge closed this as completed in #38467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment