Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort shares by title and then creation date #36906

Closed
skjnldsv opened this issue Feb 28, 2023 · 15 comments · Fixed by #37878
Closed

Sort shares by title and then creation date #36906

skjnldsv opened this issue Feb 28, 2023 · 15 comments · Fixed by #37878
Labels
3. to review Waiting for reviews 26-feedback enhancement feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone

Comments

@skjnldsv
Copy link
Member

image

Currently they are not sorted at all

this.linkShares = shares.filter(share => share.type === this.SHARE_TYPES.SHARE_TYPE_LINK || share.type === this.SHARE_TYPES.SHARE_TYPE_EMAIL)
this.shares = shares.filter(share => share.type !== this.SHARE_TYPES.SHARE_TYPE_LINK && share.type !== this.SHARE_TYPES.SHARE_TYPE_EMAIL)

@skjnldsv skjnldsv added enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 1. to develop Accepted and waiting to be taken care of feature: sharing 26-feedback labels Feb 28, 2023
@skjnldsv skjnldsv added this to the Nextcloud 27 milestone Feb 28, 2023
@skjnldsv skjnldsv changed the title Sort shares by types, title and then creation date Sort shares by title and then creation date Feb 28, 2023
@oraliahdz
Copy link

HI, I would like to help. Is this still available?

@SamantaTarun
Copy link

I'd like to work on this issue. Please assign it to me.

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 1, 2023

To both of you , you don't have to ask, feel free to fork and fix the issue, then create a pull request :)
https://github.com/nextcloud/server#contribution-guidelines-

@skjnldsv skjnldsv added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Mar 7, 2023
@SamantaTarun
Copy link

@skjnldsv how to run on localhost? Please type the command here.

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 7, 2023

@skjnldsv how to run on localhost? Please type the command here.

https://github.com/nextcloud/server#join-the-team-

@SamantaTarun
Copy link

@skjnldsv please check my latest pr as I couldn't run it on localhost

@SamantaTarun
Copy link

@skjnldsv
Please tell me how to view that share window.

image

@SamantaTarun
Copy link

@skjnldsv

now tell me what i have to do?
image

@SamantaTarun
Copy link

@skjnldsv

image

@SamantaTarun
Copy link

@skjnldsv
image

@SamantaTarun
Copy link

SamantaTarun commented Mar 18, 2023

@skjnldsv

I believe it's working perfectly. You can merge now.

@skjnldsv
Copy link
Member Author

image
This doesn't look alphabetically sorted

@SamantaTarun
Copy link

SamantaTarun commented Mar 18, 2023

@skjnldsv it doesn't look alphabetically sorted as temp2 is created after temp1. So first Sort will be according to the title, followed by the created time.

@SamantaTarun
Copy link

@skjnldsv i got your point.

@skjnldsv skjnldsv removed this from the Nextcloud 27.0.2 milestone Aug 8, 2023
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 23, 2024
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews 26-feedback enhancement feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
5 participants