Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update via UI breaks with future version of symfony/event-dispatcher #33264

Closed
2 tasks done
nickvergessen opened this issue Jul 18, 2022 · 0 comments · Fixed by #33640
Closed
2 tasks done

Update via UI breaks with future version of symfony/event-dispatcher #33264

nickvergessen opened this issue Jul 18, 2022 · 0 comments · Fixed by #33640
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: install and update regression
Milestone

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Jul 18, 2022

TypeError: Symfony\\Component\\EventDispatcher\\GenericEvent::getArgument(): Argument #1 ($key) must be of type string, int given, called in /var/www/nextcloud/server/lib/private/EventDispatcher/GenericEventWrapper.php on line 81 at /var/www/nextcloud/server/appsbabies/spreed/vendor/symfony/event-dispatcher/GenericEvent.php#60

We have several events which use int based arrays for the arguments:

  • lib/private/DB/Migrator.php
    $this->dispatcher->dispatch('\OC\DB\Migrator::executeSql', new GenericEvent($sql, [$step + 1, $max]));
  • lib/private/Repair.php
    public function emit($scope, $method, array $arguments = []) {
    if (!is_null($this->dispatcher)) {
    $this->dispatcher->dispatch("$scope::$method",
    new GenericEvent("$scope::$method", $arguments));
    }
    }

We can adjust them already now to have string based arguments which is a much better description.

@come-nc come-nc linked a pull request Aug 22, 2022 that will close this issue
@come-nc come-nc added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Aug 25, 2022
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 30, 2022
@come-nc come-nc added this to the Nextcloud 25 milestone Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: install and update regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants