Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to activate bright mode when in dark mode #32176

Closed
Tracked by #32072
szaimen opened this issue Apr 27, 2022 · 6 comments · Fixed by #32195
Closed
Tracked by #32072

No way to activate bright mode when in dark mode #32176

szaimen opened this issue Apr 27, 2022 · 6 comments · Fixed by #32195
Assignees
@skjnldsv
Labels
3. to review Waiting for reviews 25-feedback design Design, UI, UX, etc. enhancement feature: theming
Milestone
Nextcloud 25

Comments

@szaimen
Copy link
Contributor

szaimen commented Apr 27, 2022

After #31751:

When your system in in dark mode, Nextcloud will be shown in dark mode as well because the default theming option respects this setting. There is unfortunatley no way to enable bright mode then anymore.

cc @skjnldsv @jancborchardt @nimishavijay how could we solve that?
@szaimen szaimen added enhancement design Design, UI, UX, etc. 0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback labels Apr 27, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Apr 27, 2022
@xeruf
Copy link

xeruf commented Apr 27, 2022

classically as it is done in many android apps: Dropdown to choose dark/light/follow system

@xeruf

This comment was marked as resolved.

Sign in to view
@szaimen

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv self-assigned this Apr 27, 2022
@skjnldsv skjnldsv added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 27, 2022
@szaimen szaimen mentioned this issue Apr 27, 2022
Closed
46 tasks
@skjnldsv
Copy link
Member

@jancborchardt @nimishavijay
image

How do you want to tackle that UX/UI wise? Shall we add a dedicated entry named "system default" ?

@szaimen
Copy link
Contributor Author

szaimen commented Apr 27, 2022 •
edited by skjnldsv
Loading

@jancborchardt @nimishavijay image

How do you want to tackle that UX/UI wise? Shall we add a dedicated entry named "system default" ?

Sounds good to me. This should then be the default option, imo :)

@skjnldsv skjnldsv mentioned this issue Apr 27, 2022
Merged
@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: theming and removed 2. developing Work in progress labels Apr 28, 2022
@skjnldsv
Copy link
Member

Done @jancborchardt and @nimishavijay, see #32195 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews 25-feedback design Design, UI, UX, etc. enhancement feature: theming
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging a pull request may close this issue.

Add system/light themes nextcloud/server
3 participants
@xeruf @skjnldsv @szaimen