Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'maximum.supported.desktop.version' parameter #30143

Closed
eibex opened this issue Dec 7, 2021 · 4 comments · Fixed by #49517
Closed

Add 'maximum.supported.desktop.version' parameter #30143

eibex opened this issue Dec 7, 2021 · 4 comments · Fixed by #49517
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish client: 💻 desktop client: 🤖🍏 mobile enhancement feature: dav good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone

Comments

@eibex
Copy link

eibex commented Dec 7, 2021

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Prevent issues like nextcloud/desktop#4016 by allowing admins to test new versions.

Describe the solution you'd like
Add 'maximum.supported.desktop.version' config parameter, especially considering that 'minimum.supported.desktop.version' already exists

Describe alternatives you've considered
Conflicts between local and remote should result in user prompts and/or remote having more importance. This alternative should be discussed in the desktop repository though.

Additional context
n.a.

@eibex eibex added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Dec 7, 2021
@eibex
Copy link
Author

eibex commented Apr 12, 2023

Relevant again with nextcloud/desktop#5564

@joshtrichards
Copy link
Member

Should be a relatively straightforward PR (I think!) for someone with light PHP skills that is looking to get involved or contribute to Nextcloud.

Basically this, slightly modified:

https://github.com/nextcloud/server/blob/master/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php

I.e. An adaptation of the existing support for minimum.supported.desktop.version that already exists.

@joshtrichards joshtrichards added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. feature: dav labels Sep 1, 2023
@flooxo
Copy link

flooxo commented Oct 29, 2023

I have added a configuration parameter, but I am not sure if these tests need to be adjusted as well. Maybe you can give me some advice?
For example here:
https://github.com/nextcloud/server/blob/master/apps/dav/tests/unit/Connector/Sabre/BlockLegacyClientPluginTest.php?#L77-L81

@skjnldsv skjnldsv self-assigned this Nov 27, 2024
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 27, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 27, 2024
@skjnldsv
Copy link
Member

Thanks @flooxo for the work on #41183 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish client: 💻 desktop client: 🤖🍏 mobile enhancement feature: dav good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
4 participants