Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalDAV availibility settings design polishing #29319

Closed
Tracked by #1
ChristophWurst opened this issue Oct 19, 2021 · 1 comment · Fixed by #29590
Closed
Tracked by #1

CalDAV availibility settings design polishing #29319

ChristophWurst opened this issue Oct 19, 2021 · 1 comment · Fixed by #29590
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug
Milestone

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 19, 2021

We should polish the design of the availability settings from #27422 / #27466 before the release of 23

This is what it looks like right now

Bildschirmfoto von 2021-10-19 11-52-36

  • Delete/Add buttons not aligned with the time pickers
  • Text between time pickers has unbalanced white space left/right
  • "Please select a time zone:" should possibly lose the ":"

@GretaD @nimishavijay may I ask you two to look into this? You've worked on the first version :)

@ChristophWurst ChristophWurst added bug 1. to develop Accepted and waiting to be taken care of 23-feedback labels Oct 19, 2021
@nimishavijay
Copy link
Member

nimishavijay commented Oct 20, 2021

Got it! Some more thoughts from my end:

  • - Agreed with points 1 and 2
  • - Left align time zone picker with the time fields
  • - For point 3, how about "Please select a time zone:" → "Time zone:" (leaving out the ":" makes it look sort of like a heading of a table, especially if you align the time zone field with the time fields below)
  • - Change colour of trash icon to something lighter like grey, full black makes look harsh
  • - Maybe we can also add some text when there are so slots set in a day, like "No working hours set" or something similar
  • - I was also wondering if it would make sense to change the "Add slot" button to a plus icon and align all of them, regardless of whether or not a time field is filled
  • - How would it look with multiple time slots for one day?
  • - What is the function of the save button? If this automatically saves then we can get rid of it

image
Made some quick mockups, would love to hear thoughts from you and @GretaD as well
cc @jancborchardt whenever he sees this

@ChristophWurst ChristophWurst added this to the Nextcloud 23 milestone Oct 25, 2021
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Nov 4, 2021
@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress labels Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants