Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admins cannot change passwords anymore on Users page #2284

Closed
blizzz opened this issue Nov 23, 2016 · 12 comments · Fixed by #2417
Closed

Admins cannot change passwords anymore on Users page #2284

blizzz opened this issue Nov 23, 2016 · 12 comments · Fixed by #2417

Comments

@blizzz
Copy link
Member

blizzz commented Nov 23, 2016

Either success or failure, the response is not dealt with. The text input stays as is and there is no confirmation.

@MorrisJobke
Copy link
Member

You shall search the bug tracker first 🔮 #2279

@MorrisJobke
Copy link
Member

Even nearly the same wording ;)

@MorrisJobke
Copy link
Member

And the same labels ;)

@LukasReschke
Copy link
Member

Well. Password != email but fair enough 😉

@blizzz
Copy link
Member Author

blizzz commented Nov 23, 2016

@MorrisJobke the issue is caused by the blurFunction from 3ffd9a7

@schiessle
Copy link
Member

@MorrisJobke the issue is caused by the blurFunction from 3ffd9a7

yes, I just tested it. Password change work, this is just a UI issue that the user get no success message. If it fails, e.g. because of the password policy app the error message also is no longer displayed correctly.

@MorrisJobke
Copy link
Member

Ah - okay - then I missed this one. I will have a look tomorrow

@MorrisJobke MorrisJobke self-assigned this Nov 23, 2016
@MorrisJobke
Copy link
Member

OC.PasswordConfirmation.requiresPasswordConfirmation() evaluates to false even if it is needed 🤔

@MorrisJobke
Copy link
Member

Introduced with #2216

@MorrisJobke
Copy link
Member

@nickvergessen Could you have a look - this does not seem to be because of the callbacks, but because the require check is wrong.

@MorrisJobke MorrisJobke removed their assignment Nov 24, 2016
@blizzz
Copy link
Member Author

blizzz commented Nov 28, 2016

@MorrisJobke no, one problem is already the use of this in the callback..

@MorrisJobke
Copy link
Member

Fix is in #2417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants