-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document changes made to the Test class for NC11 #2135
Comments
Sample of the breakage which happens after the changes on PHP 7:
|
The actual change is that since we now require php 5.6+ we also require phpunit 5+ |
Actually, that's the exact version being used:
|
OK, after re-reading this, I guess it's a problem with PHPUnit which will never be fixed.
Since PHPUnit 5 still support 5.6. There should be a note somewhere about that change so that all app devs can update their Travis. |
I added 100 lines of magic to fix it: #2137 |
Great, thanks!. Let's close this then if that was the only problem linked to PHP 5.6 and testing. |
There have been breaking changes made to the Test class and devs need:
cc @rullzer @nickvergessen @LukasReschke , but feel free to share with others ;)
The text was updated successfully, but these errors were encountered: