Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to not crop images on grid view #18439

Closed
skjnldsv opened this issue Dec 17, 2019 · 1 comment · Fixed by #25055
Closed

Option to not crop images on grid view #18439

skjnldsv opened this issue Dec 17, 2019 · 1 comment · Fixed by #25055
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Dec 17, 2019 •
edited
Loading

So, it would just be a matter of adding &a=1 to the preview url.

server/apps/files/js/filelist.js

Line 2150 in f3cdf7e

generatePreviewUrl: function(urlSpec) {

image1

This is something we could add as a setting in the bottom left in Files (and Photos)?

The setting should be "Crop image previews" and be checked by default.

Cause we had the same discussion around Photos, and there’s no clear right or wrong. We use cropping as default, but just like macOS has it as an different view to not have it cropped, we should probably have it as an option too. Something for 19 though.

cc @jancborchardt
@skjnldsv skjnldsv added enhancement design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 1. to develop Accepted and waiting to be taken care of feature: files labels Dec 17, 2019
@jancborchardt
Copy link
Member

jancborchardt commented Dec 17, 2019 •
edited
Loading

Just a detail: The setting should be "Crop image previews" and be checked by default.

That is, the current way of cropping stays the default.

@jancborchardt jancborchardt added this to the Nextcloud 19 milestone Dec 17, 2019
@rullzer rullzer removed this from the Nextcloud 19 milestone Apr 10, 2020
@nina-py nina-py mentioned this issue Jan 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "Crop image previews" setting to files
3 participants
@rullzer @jancborchardt @skjnldsv