Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue login page #15584

Closed
ChristophWurst opened this issue May 17, 2019 · 7 comments · Fixed by #15647
Closed

Vue login page #15584

ChristophWurst opened this issue May 17, 2019 · 7 comments · Fixed by #15647

Comments

@ChristophWurst
Copy link
Member

Is your feature request related to a problem? Please describe.

The login page is plain old jQuery.

Describe the solution you'd like

I would like to replace that with a Vue component.

Describe alternatives you've considered

n/a

Additional context

https://github.com/orgs/nextcloud/projects/31


@nextcloud/javascript @nextcloud/vue objects? Could this break any third party apps that inject random stuff into that page? If so, should we add proper APIs for that stuff?

@ChristophWurst ChristophWurst added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap technical debt labels May 17, 2019
@rullzer
Copy link
Member

rullzer commented May 17, 2019

@nextcloud/javascript @nextcloud/vue objects? Could this break any third party apps that inject random stuff into that page? If so, should we add proper APIs for that stuff?

I would like this very much. It would also allow us to kill all extra JS etc beging served (with posisble preloading of the main file etc later).

Of course we'd have to know if some apps inject stuff here (imprint app maybe?).
But like you said I'd much rather add a nice API to do this properly. Than to support random hacks.

@georgehrke
Copy link
Member

If I'm not completely mistaken, the registration app is also hooking into the login page.

@MorrisJobke
Copy link
Member

If I'm not completely mistaken, the registration app is also hooking into the login page.

But it does this via the "alternative login" API, right?

@MorrisJobke
Copy link
Member

Same goes for user_saml.

@skjnldsv
Copy link
Member

Yep, I agree with @MorrisJobke
I would actually try to limit a lot what can be added there. :)
Or at least make the design very consistent and not let anyone add anything.

@georgehrke
Copy link
Member

But it does this via the "alternative login" API, right?

cc @pellaeon

@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels May 27, 2019
@ChristophWurst
Copy link
Member Author

WIP PR is at #15647

@MorrisJobke MorrisJobke added this to the Nextcloud 17 milestone May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants