Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted files do not show up #14336

Closed
kruthoff opened this issue Feb 22, 2019 · 5 comments
Closed

Deleted files do not show up #14336

kruthoff opened this issue Feb 22, 2019 · 5 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug

Comments

@kruthoff
Copy link

Steps to reproduce

  1. Click "Deleted files"

Expected behaviour

List of deleted files

Actual behaviour

White page loading forever...

Server configuration

Operating system:
linux

Web server:
nginx

Database:
postgres

PHP version:
7.0

Nextcloud version: (see Nextcloud admin page)
15.0.4.0

Updated from an older Nextcloud/ownCloud or fresh install:
updated (showing deleted files was working on earlier installations...)

Operating system:
raspbian 9.8

Logs

Nextcloud log (data/nextcloud.log)

Nextcloud log
[remote] Error: TypeError: Return value of OCA\Files_Trashbin\Sabre\AbstractTrash::getSize() must be of the type integer, float returned at <<closure>>

 0. /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/PropFind.php line 98
    getSize()
 1. /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php line 797
    handle("{DAV:}getcontentlength", [OCA\Files_Trash ... "])
 2. <<closure>>
    propFind(Sabre\DAV\PropFind {}, OCA\Files_Trashbin\Sabre\TrashFile {})
 3. /var/www/html/nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php line 105
    call_user_func_array([Sabre\DAV\CorePlugin {},"propFind"], [Sabre\DAV\PropF ... }])
 4. /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 1059
    emit("propFind", [Sabre\DAV\PropF ... }])
 5. /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 981
    getPropertiesByNode(Sabre\DAV\PropFind {}, OCA\Files_Trashbin\Sabre\TrashFile {})
 6. /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 1666
    getPropertiesIteratorForPath("trashbin/andreas/trash", ["{http://nextcl ... "], 1)
 7. /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php line 355
    generateMultiStatus(Generator {}, false)
 8. <<closure>>
    httpPropFind(Sabre\HTTP\Reque ... "}, Sabre\HTTP\Response {})
 9. /var/www/html/nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php line 105
    call_user_func_array([Sabre\DAV\CorePlugin {},"httpPropFind"], [Sabre\HTTP\Requ ... }])
10. /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 479
    emit("method:PROPFIND", [Sabre\HTTP\Requ ... }])
11. /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 254
    invokeMethod(Sabre\HTTP\Reque ... "}, Sabre\HTTP\Response {})
12. /var/www/html/nextcloud/apps/dav/lib/Server.php line 301
    exec()
13. /var/www/html/nextcloud/apps/dav/appinfo/v2/remote.php line 35
    exec()
14. /var/www/html/nextcloud/remote.php line 163
    require_once("/var/www/html/n ... p")

PROPFIND /remote.php/dav/trashbin/andreas/trash
from 185.12.128.225 by andreas at 2019-02-22T08:05:14+01:00
@kruthoff kruthoff added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Feb 22, 2019
@atsag
Copy link

atsag commented Feb 22, 2019

This error also affects me on the same Nextcloud version, Raspbian 9.6 and may have to do with #13005 and #13428. I updated from 15.0.2 to 15.0.4 and this issue is present in both. The first line of the error is the same as above.

@jpschewe
Copy link

I'm seeing this on tinkeros as well.

In the client javascript window I see the following:

Content Security Policy: Directive ‘child-src’ has been deprecated. Please use directive ‘worker-src’ to control workers, or directive ‘frame-src’ to control frames respectively.
Content Security Policy: The page’s settings blocked the loading of a resource at eval (“script-src”).
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”). files:1:1
JQMIGRATE: Migrate is installed, version 1.4.0 core.js:7:542
unreachable code after return statement[Learn More] merged.js:1563:4
window.controllers/Controllers is deprecated. Do not use it for UA detection. merged.js:2176
New search handler registered search.js:67:4
querying Whats New data was successful: nocontent merged-template-prepend.js:4613:4
undefined merged-template-prepend.js:4614:4
TypeError: xml is null[Learn More] client.js:430:8

Once I've gotten this error I can't do anything in the client interface without forcing a reload of the page.

@jpschewe
Copy link

I got about this by editing apps/files_trashbin/lib/Sabre/AbstractTrash.php and adding a call to intval around the return value of getSize.

@madiele
Copy link

madiele commented Apr 25, 2019

I found the same problem, here the logs, I'm on 15.0.7

TypeError: Return value of OCA\Files_Trashbin\Sabre\AbstractTrash::getSize() must be of the type integer, float returned

    /var/www/html/nextcloud/apps/files_trashbin/lib/Sabre/PropfindPlugin.php - line 78:

    OCA\Files_Trashbin\Sabre\AbstractTrash->getSize()

    /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/PropFind.php - line 98:

    OCA\Files_Trashbin\Sabre\PropfindPlugin->OCA\Files_Trashbin\Sabre\{closure}("*** sensiti ... *")

    /var/www/html/nextcloud/apps/files_trashbin/lib/Sabre/PropfindPlugin.php - line 79:

    Sabre\DAV\PropFind->handle("{http://owncloud.org/ns}size", Closure {})

    <<closure>>

    OCA\Files_Trashbin\Sabre\PropfindPlugin->propFind(Sabre\DAV\PropFind {}, OCA\Files_Tr ... {})

    /var/www/html/nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php - line 105:

    call_user_func_array([ OCA\Files_ ... "], [ Sabre\DAV\ ... }])

    /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 1059:

    Sabre\Event\EventEmitter->emit("propFind", [ Sabre\DAV\ ... }])

    /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 981:

    Sabre\DAV\Server->getPropertiesByNode(Sabre\DAV\PropFind {}, OCA\Files_Tr ... {})

    /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 1666:

    Sabre\DAV\Server->getPropertiesIteratorForPath("trashbin/madiele/trash", [ "{http://n ... "], 1)

    /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php - line 355:

    Sabre\DAV\Server->generateMultiStatus(Generator {}, false)

    <<closure>>

    Sabre\DAV\CorePlugin->httpPropFind(Sabre\HTTP\R ... "}, Sabre\HTTP\Response {})

    /var/www/html/nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php - line 105:

    call_user_func_array([ Sabre\DAV\ ... "], [ Sabre\HTTP ... }])

    /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 479:

    Sabre\Event\EventEmitter->emit("method:PROPFIND", [ Sabre\HTTP ... }])

    /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 254:

    Sabre\DAV\Server->invokeMethod(Sabre\HTTP\R ... "}, Sabre\HTTP\Response {})

    /var/www/html/nextcloud/apps/dav/lib/Server.php - line 301:

    Sabre\DAV\Server->exec()

    /var/www/html/nextcloud/apps/dav/appinfo/v2/remote.php - line 35:

    OCA\DAV\Server->exec()

    /var/www/html/nextcloud/remote.php - line 163:

    require_once("/var/www/ht ... p")

and here the logs it produce if I try to access the bin through the android app

Sabre\DAV\Exception: The REQUEST_URI (/nextcloud/remote.php/dav/trashbin/madiele/trash//) did not end with the contents of PATH_INFO (/dav/trashbin/madiele/trash/). This server might be misconfigured.

    /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 349:

    Sabre\DAV\Server->guessBaseUri()

    /var/www/html/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php - line 253:

    Sabre\DAV\Server->getBaseUri()

    /var/www/html/nextcloud/remote.php - line 72:

    Sabre\DAV\Server->exec()

    /var/www/html/nextcloud/remote.php - line 168:

    handleException(TypeError {})

as a workaround I tried the workaround referenced here, and it worked for now

@kesselb
Copy link
Contributor

kesselb commented Jul 6, 2019

Thank you for reporting this issue +1

Please check this report for further information: #13160

@kesselb kesselb closed this as completed Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Development

No branches or pull requests

5 participants