Provide avatar URL on share information

[tobiasKaminsky]

Currently we "only" get infos on user who shared with "me" separate, via
http://localhost/nc/ocs/v2.php/apps/files_sharing/api/v1/shares?path=/123&reshares=true&subfiles=true&shared_with_me=true

…
<uid_owner>test</uid_owner>
<displayname_owner>test</displayname_owner>
…

Every client now has to build the avatar url by its own.

As discussed with @schiessle, this should be simplified, so that the avatar url is generated on server side and clients can directly retrieve them.

Please with eTags 👍
And, if possible, for all users listed in the response (sharee and share owner)

(planned for NC15)

[nextcloud-bot]

GitMate.io thinks possibly related issues are #9182 (Just a question // Feature request // Pretty Share URL), #4334 (Improve sharing email information), #6881 ([Suggestion] Nice urls: make share links becoming nice), #2658 (Sharing and permissions), and #1575 ([Feature Request] Add configuration for "Sharing URL").

[schiessle]

cc @rullzer maybe also something for you if you have some time. It is probably not that hard, someone "just" need to find the time to do it 😉

[rullzer]

Adding the URL there should not be that hard. But adding the etag is a bit hard and a bit weird. It requires a lot of additonal logic with no real point imo.

I'd vote to just add the link to the avatar.
Then you can do the logic you want yourself. You can show the cached avatar and try to fetch a new one in the back etc.

[tobiasKaminsky]

The idea with eTag was that clients then do not have to query the avatar url as they directly know if an avatar is out of date.
But if eTags are too hard, then we can remove it.
(eTag on avatar is already in place, but only when calling/downloading it and we use it there already)

[tobiasKaminsky]

Can we have this for NC17? Please :-)

[skjnldsv]

Is this still needed?
You have the owner uid, you shouldn't need anything else, no?
We don't use it for the server sidebar, so I guess it's fine now?

[tobiasKaminsky]

True, this is already done via nc:sharees.