Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not always assume en-US as language if we cannot clearly determine #500

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 6, 2023

Fix #100

Previously we try to match our language/locale setting to a predefined list, but with some like zh_CN we didn't find the supported zh-CN.

The office documentation points that any value can be passed over:

https://learn.microsoft.com/en-us/microsoft-365/cloud-storage-partner-program/online/discovery#ui_llcc

In addition to the values provided in the Locale ID column, you can supply any language, provided it's in the format described in RFC 1766. If you don't set a value for this placeholder, Office for the web tries to use the browser language setting (navigator.language). If no valid language can be determined, Office for the web defaults to en-US (US English).

@juliusknorr juliusknorr requested review from blizzz and mejo- December 6, 2023 18:29
@juliusknorr juliusknorr mentioned this pull request Dec 6, 2023
@juliusknorr juliusknorr added 3. to review Waiting for reviews bug Something isn't working labels Dec 6, 2023
@juliusknorr juliusknorr merged commit ec72510 into main Dec 7, 2023
22 checks passed
@juliusknorr juliusknorr deleted the bugfix/100 branch December 7, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

russian language
2 participants