Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional parameter $forceIcon declared before required parameter $mode #587

Closed
koelle25 opened this issue Sep 4, 2024 · 1 comment · Fixed by #604
Closed

Optional parameter $forceIcon declared before required parameter $mode #587

koelle25 opened this issue Sep 4, 2024 · 1 comment · Fixed by #604

Comments

@koelle25
Copy link

koelle25 commented Sep 4, 2024

Describe the bug
Following PHP error is logged in nextcloud.log:

[PHP] Fehler: Optional parameter $forceIcon declared before required parameter $mode is implicitly treated as a required parameter at /var/www/html/custom_apps/officeonline/lib/Controller/TemplatesController.php#196
	GET /csrftoken
	von 10.0.11.4 von kevin.koellmann um 04.09.2024, 10:04:32

To Reproduce
Steps to reproduce the behavior:

  1. Open a document in Nextcloud web interface, so it gets opened with the Office Online integration
  2. Go to 'https://<yourcloud.com>/settings/admin/logging'
  3. See error

Expected behavior
No error in log.

Screenshots
-/-

Client details:

  • OS: Windows 11
  • Browser: Firefox
  • Version: 115 ESR
  • Device: Desktop

Server details

Operating system: Ubuntu 22.04

Web server: NGINX

Database: MariaDB

PHP version: 8.2.23

Nextcloud version: 29.0.6

Version of the officeonline app: 2.2.1

Version of Office Online server: 16.0.8471.8525

Logs

Nextcloud log (data/nextcloud.log)

{"reqId":"hVXMJViROkKZxGCYdA2o","level":3,"time":"2024-09-04T10:04:32+02:00","remoteAddr":"10.0.11.4","user":"kevin.koellmann","app":"PHP","method":"GET","url":"/csrftoken","message":"Optional parameter $forceIcon declared before required parameter $mode is implicitly treated as a required parameter at /var/www/html/custom_apps/officeonline/lib/Controller/TemplatesController.php#196","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/115.0","version":"29.0.6.1","data":{"app":"PHP"},"id":"66d8172b1ef2e"}

Browser log


@IGLADI
Copy link

IGLADI commented Sep 7, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants