Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit text horizontally #182

Closed
bszente opened this issue Mar 27, 2018 · 4 comments · Fixed by #290
Closed

Fit text horizontally #182

bszente opened this issue Mar 27, 2018 · 4 comments · Fixed by #290
Assignees
Labels
design Related to the design or user experience enhancement New feature or request good first issue Should be easy to implement
Milestone

Comments

@bszente
Copy link

bszente commented Mar 27, 2018

The notes on large (FullHD) screens are auto-wrapped at 47em leaving a large portion of empty white screen on right side. This is caused by the following line in notes.css:

max-width: 47em;

Please remove this static width limitation and enable fit-to-width behavior.

@elpraga
Copy link

elpraga commented Mar 27, 2018

Could this be related to #177 ?

@bszente
Copy link
Author

bszente commented Mar 28, 2018

I don't know if this is related to your issue. Can you please test, if removing this line from CSS fixes the rendering on Android?

@elpraga
Copy link

elpraga commented Mar 28, 2018

I just tried that. It didn't fix my problem. Thanks for your help!

@camilasan camilasan added enhancement New feature or request good first issue Should be easy to implement labels May 4, 2018
@jancborchardt
Copy link
Member

Right, on big screens it indeed looks a bit strange as it’s all left-aligned.

The reason we limit the width though is for legibility, see https://en.wikipedia.org/wiki/Line_length

So we should add some CSS with a media query for big screen widths to properly center the content:

#app-content-container {
    text-align: center;
}

.CodeMirror {
    display: inline-block;
    text-align: center;
    margin-right: 125px; /* half of the app-navigation width, to offset a bit to the left so it’s centered related to viewport */
}

@jancborchardt jancborchardt changed the title Fit text horizontally: please remove the "max-width: 47em" from CSS Fit text horizontally Jun 4, 2018
@jancborchardt jancborchardt self-assigned this Jun 4, 2018
@jancborchardt jancborchardt added this to the 2.4.0 milestone Jun 4, 2018
@korelstar korelstar added the design Related to the design or user experience label Nov 18, 2018
@korelstar korelstar removed this from the M1 – 🐛 Detail fixes milestone Dec 21, 2018
@korelstar korelstar mentioned this issue May 18, 2019
54 tasks
@korelstar korelstar added this to the 3.0.0 milestone May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to the design or user experience enhancement New feature or request good first issue Should be easy to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants