Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links not clickable #173

Open
d-sko opened this issue Mar 2, 2018 · 17 comments
Open

Links not clickable #173

d-sko opened this issue Mar 2, 2018 · 17 comments
Labels
enhancement New feature or request feature: EasyMDE Realted to the integrated EasyMDE editor help wanted Complex issue or we don't know how to fix it

Comments

@d-sko
Copy link

d-sko commented Mar 2, 2018

Hello, I've installed this app in my nextcloud and noticed a problem: I have some notes with links in it and they are not clickable (but they are actually displayed as links). Is this intended or am I doing something wrong?

nc_notes_link


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Larsene
Copy link

Larsene commented Mar 12, 2018

Already reported here

@d-sko
Copy link
Author

d-sko commented Mar 19, 2018

Oh, sorry I missed that.

Closing because duplicate of #158

@d-sko d-sko closed this as completed Mar 19, 2018
@jancborchardt jancborchardt reopened this Jun 4, 2018
@jancborchardt
Copy link
Member

Reopening cause this issue is specifically about that one problem. :)

@jancborchardt jancborchardt added bug Something isn't working help wanted Complex issue or we don't know how to fix it good first issue Should be easy to implement labels Jun 4, 2018
@jancborchardt jancborchardt changed the title links not clickable? Links not clickable Jun 4, 2018
@jancborchardt jancborchardt added this to the 2.4.0 milestone Jun 4, 2018
@stefan-niedermann
Copy link
Member

Have you tried ctrl + click? I thought this would work...

@tribut
Copy link

tribut commented Jun 5, 2018

ctrl+ click works, but it also creates a second cursor (a feature which I was not aware the markdown editor had).

@tribut
Copy link

tribut commented Jun 5, 2018

Note that ctrl + click only works on manually set up links ([name](target)) while it seems to do nothing except creating multiple cursors on auto-detected urls.

@stefan-niedermann
Copy link
Member

i see. single click is disabled like in microsoft word and libreoffice writer, because if one wants to edit the link or the text, one could only open the link and not set the cursor.

@jancborchardt
Copy link
Member

@stefan-niedermann I’d still say we should enable single-click because Ctrl-Click is not really discoverable. If the link should be edited, people can still click next to it and use the arrow keys – I know, also not ideal, but less bad than not being able to click the link :\ Is that possible?

@stefan-niedermann
Copy link
Member

Technically yes. But i would recommend to wait for the text-pop-over: Click on a link could create a pop over with an "open"-button. this way one could still click into links to edit them. What do you think?

Every other text-editor that is capable of displaying and opening links uses ctrl + click to open the links...

@jancborchardt
Copy link
Member

Every other text-editor that is capable of displaying and opening links uses ctrl + click to open the links...

That's only the case for mostly code editors. :) FoldingText and iA Writer for example open links on click, and I do agree it's confusing from a user perspective that click doesn't open a link.

The popover from #200 is also only intended to come when you mark text, not when you click.

@stefan-niedermann
Copy link
Member

alternatively displaying an icon right next to a link would be a solution, too?

@tribut
Copy link

tribut commented Jun 6, 2018

Actually, LibreOffice only displays a tooltip on hover:

libreoffice-writer

Same behavior on Word (2010):

word-2010

If "Rightclick -> Open in new tab/window" works, I would argue ctrl+click is actually fine and consistent with other editors.

@mmccarn
Copy link

mmccarn commented Jun 7, 2018

I would add to this that on OSX (High Sierra), <ctrl>-click is intercepted by the OS and interpreted as a right-click, which gives me the browser right-click menu.

<Command⌘>-click does insert extra cursors as described by tribut but still doesn't open the link.

@jancborchardt
Copy link
Member

Again:

FoldingText and iA Writer for example open links on click, and I do agree it's confusing from a user perspective that click doesn't open a link.

I would say that neither LibreOffice nor Word are a really good benchmark when it comes to distraction-free working.

Right now we have the problem that you can not click the link at all and it is very cumbersome to get to it. Ctrl-click is not possible on touch-interfaces, or in touch-modes of desktop computers (like Surface etc). Hence the easiest way to fix this for now is to make clicking open the link. As you can then still modify the link by clicking next to it and then moving your cursor, or by marking, or if possible we could use ctrl-click for that.

The point being that after insertion, you probably click a link more often than you edit it. And yes, in Markdown-format links like [Text](https://…) clicking the text part of the link should not open the link so it’s easy to edit the text.

@brandonkirsch
Copy link

Weighing in on an old issue.

On my web browser: Ctrl+Click only follows a hyperlink when I click on one that has been formatted in Markdown properly.

I find it extremely annoying that I cannot Ctrl+Click a hyperlink that was formatted automatically when using my Desktop web browser to access Notes.

Anyone else?

@jancborchardt

This comment has been minimized.

@korelstar korelstar removed this from the M1 – 🐛 Detail fixes milestone Dec 21, 2018
@korelstar korelstar added enhancement New feature or request feature: EasyMDE Realted to the integrated EasyMDE editor and removed bug Something isn't working markdown labels May 24, 2019
@monperrus

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: EasyMDE Realted to the integrated EasyMDE editor help wanted Complex issue or we don't know how to fix it
Projects
None yet
Development

No branches or pull requests

9 participants