Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Security Scan always reporting latest patch level #1528

Open
PhrozenByte opened this issue Aug 11, 2021 · 8 comments
Open

Security Scan always reporting latest patch level #1528

PhrozenByte opened this issue Aug 11, 2021 · 8 comments
Labels
security-scan scan.nextcloud.com

Comments

@PhrozenByte
Copy link

https://scan.nextcloud.com/ currently (Scanned at 2021-08-11 20:49) reports Nextcloud instances running v20.0.10 as "latest patch level", even though the latest release is v20.0.12. This is a bug.

The rating of this server still is A+. The rating of a Nextcloud instance not running the latest patch level should be a C at max, even though there are no known vulnerabilities.

@PhrozenByte PhrozenByte added the security-scan scan.nextcloud.com label Aug 11, 2021
@isdnfan
Copy link

isdnfan commented Aug 19, 2021

same problem with 21. two different instances running 21.0.4.1 and 21.0.2.1 both reported as "latest patch level" (older scanned later)

image

The rating of a Nextcloud instance not running the latest patch level should be a C at max

this is not right per definition:

image

the rating of an instance running previous version could be A+ if no vulnerabilities are known and new versions don't ship additional hardening - but it definitely must not indicate "latest patch level". The definition lacks of B grade - maybe this was intended to gradually reduce rating for older patches without known vulnerabilities?

PS: it become even more funny 22.1.0.1 is not "latest" while 21.x.x.x still is..

image

@PhrozenByte
Copy link
Author

this is not right per definition:

I was indeed rather aiming to change the definition.

A service not running the latest available patch version must be considered insecure by definition, as the admin isn't utilizing the most basic security measure: to keep software up-to-date at all times. There might be a reasonable grace period (maybe a couple of days) after a new patch version has been released to allow some testing, but beyond that there's simply no reason not to update to the latest patch level. Nextcloud shouldn't endorse such conduct by still rating this "A" or even "A+".

Utilizing rating "B" is a good idea, though. It's important to note that "B" should have an orange-ish color, since it's nevertheless risky and bad to do so. If there are two later patch levels, we should end up with an "F" for "no longer supported".

Speaking of ratings, a Nextcloud instance with known vulnerabilities (rating C) is orange? Why is that? It's a security issue after all. If there is a security issue, we have a red flag for sure. I'm totally fine with differentiating how bad things are, they can always be worse, but if things are bad, they are bad ("red"), and not "still kinda okay" ("orange").

@isdnfan
Copy link

isdnfan commented Aug 22, 2021

I agree common security best practice is to update fast, but I don't agree this habit is by definition more secure. Often new version improve security and reduce vulnerabilities, but I would keep this decision on vendor's side - so far new versions don't improve security somehow there is no reason to reduce the security score of preceding versions (new may even introduce new issues because of new functionality).

One could have a discussion if A+ or A is better suited for this case but I strongly disagree the system should score orange B only because it doesn't run latest patch level - such habit makes the score completely useless. Each system should run supported and secure patch level - but given the fact new versions don't ship any security improvement there is no reason to consider them more secure..

For me A is good for each supported version without known security issues (maybe a green B - this fits more with @PhrozenByte expectations).

@PhrozenByte
Copy link
Author

PhrozenByte commented Aug 22, 2021

Each system should run supported and secure patch level

Superseded patch levels aren't supported 😉 The first thing you'll get as an answer when reporting issues with older patch levels is to update to the latest one.

The thing about this is rather easy: It's not always possible to fully comprehend whether a patch might have a security impact or not. Most patches solve issues that are no security issues itself, but might have some security impact in combination with other flaws. To be sure you have to invest quite some time for research - if even possible, considering the size of the whole Nextcloud ecosystem. Not every fix with potential security impact is a security fix and treated as such. There are "accidental security fixes", too. Furthermore, research focuses on the latest patch level - so issues with older versions can be missed by researchers.

"Best practice" doesn't mean "yeah, we all know we should, but it's still kinda okay if we don't".

If there is no reason not to update, you update. As I said earlier, there is a reasonable grace period in which delaying updates to do some stability tests is totally fine. But not for almost two months (like for Nextcloud 20.0.10 right now, which was superseded by v20.0.11 on 2021-07-01).

By the way, "yeah, we all know we should, but it's still kinda okay if we don't" pretty much sums up how an orange score is interpreted. Thus I feel like missing an update should receive a matching score.

new may even introduce new issues because of new functionality

We're talking about patch levels here, not about major updates. Nextcloud 20 reaches EOL in October and until then it still can reach A+ or A - if it's the latest patch level of course.

@isdnfan
Copy link

isdnfan commented Aug 23, 2021

The first thing you'll get as an answer when reporting issues with older patch levels is to update to the latest one.

  • Support and Security are different things.

There are "accidental security fixes"

  • Agree!
  • But there are accidental security holes..
  • unknown security problems within new functions!
  • regressions for existing functionality

If there is no reason not to update, you update.

  • agree (more or less)
  • it takes time to test if there is any regression (multiple months in my experience)
  • who pays if there are no reasons to update?
  • what is if there are reasons to not update?

We're talking about patch levels here, not about major updates.

even patch levels could introduce new functionality. I can't speak if this is the case often but this can happen. Again the vendor should decide if the previous patch is less secure than the latest one ( in general I agree older patches should have some penalty on security scanner.. but I'm not such strict as @PhrozenByte is)

@Reggiewilliamsr

This comment has been minimized.

@isdnfan
Copy link

isdnfan commented Oct 11, 2021

one currently wide recognized issue cve-2021-41773 - only affects latest - at this time - version. thousands of admins who patched to this version are under attack.. previous versions might have security issues as well but compared to the really simple break out of server context it's less urgent..

@PhrozenByte
Copy link
Author

How is this related to Nextcloud? Are you trying to make an "empirical case count: one" / "but this one time..." point? A single event doesn't change anything about what the recommendations from the majority of security researchers is. Anyway, you made your point, I made my point, neither you nor me are adding anything useful here. We've different opinions. That's okay.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
security-scan scan.nextcloud.com
Projects
None yet
Development

No branches or pull requests

3 participants