Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable7] Revert new AppSidebarTabs design #4044

Merged
merged 1 commit into from
May 5, 2023
Merged

[stable7] Revert new AppSidebarTabs design #4044

merged 1 commit into from
May 5, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented May 5, 2023 •
edited by nickvergessen
Loading

Stable 7 should not have such drastic changes so close to the freeze or the design will look different between apps as no one have time to update yet.

Revert #3945

@nickvergessen nickvergessen requested a review from ShGKme May 5, 2023 12:16
@skjnldsv skjnldsv self-assigned this May 5, 2023
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels May 5, 2023
@skjnldsv skjnldsv added this to the 7.11.3 milestone May 5, 2023
@raimund-schluessler
Copy link
Contributor

If this change is generally desired, just not for version 7, how about branching-of a stable7 branch and reverting it just there?

@nickvergessen
Copy link
Contributor

If this change is generally desired, just not for version 7, how about branching-of a stable7 branch and reverting it just there?

That is exactly what we did, this PR here is against stable7

@nickvergessen nickvergessen changed the title Revert new AppSidebarTabs design [stable7] Revert new AppSidebarTabs design May 5, 2023
@susnux
Copy link
Contributor

susnux commented May 5, 2023

Is the revert on the NcCheckboxRadioSwitch required, too?

@raimund-schluessler
Copy link
Contributor

If this change is generally desired, just not for version 7, how about branching-of a stable7 branch and reverting it just there?

That is exactly what we did, this PR here is against stable7

Sorry, I missed that 🙈

@skjnldsv
Copy link
Contributor Author

skjnldsv commented May 5, 2023

Is the revert on the NcCheckboxRadioSwitch required, too?

I kinda don't want to take risks tbh 🤷

@skjnldsv skjnldsv merged commit 73589e7 into stable7 May 5, 2023
@skjnldsv skjnldsv deleted the revert-3945-feat/nc-pill-menu branch May 5, 2023 13:59
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 5, 2023
@nickvergessen nickvergessen mentioned this pull request May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@susnux susnux Awaiting requested review from susnux

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
7.11.3
Development

Successfully merging this pull request may close these issues.
5 participants
@skjnldsv @raimund-schluessler @nickvergessen @susnux @marcelklehr