-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NcActions
component for NcAvatar
#4017
Conversation
30e65db
to
2d5f161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NcActions
component for NcAvatar
Signed-off-by: Raimund Schlüßler <[email protected]>
2d5f161
to
6be00c3
Compare
You're right, I guess it's because I have a dark theme and it's much easier to see the three dot icon there than the light theme tbh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine now
:deep() { | ||
.button-vue, | ||
.button-vue__icon { | ||
height: var(--size); | ||
min-height: var(--size); | ||
width: var(--size) !important; | ||
min-width: var(--size); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a size/small prop to NcButton
instead of deep internal classes overrides?
This PR migrates the
NcAvatar
component from using the deprecatedNcPopoverMenu
toNcActions
.Closes #1683, closes #1762