Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Undo" message doesn't resize if text is longer #6364

Closed
Chartman123 opened this issue May 5, 2022 · 5 comments · Fixed by nextcloud-libraries/nextcloud-dialogs#582
Closed

Comments

@Chartman123
Copy link

Steps to reproduce

  1. Send an email with e.g. German user language
  2. See "undo" message is not really readable

Expected behavior

Message popup should resize to the text length + button width

Actual behavior

Message popup seems to have a fixed with:

image

Mail app version

1.12.0

Mailserver or service

No response

Operating system

No response

PHP engine version

PHP 8.0

Web server

Apache (supported)

Database

PostgreSQL

Additional info

No response

@ChristophWurst
Copy link
Member

Possibly a bug of https://github.com/nextcloud/nextcloud-dialogs/ because I don't think this app influences how the text is styled

@Chartman123
Copy link
Author

Yes, possible. Should I open a bug report over there? The problem here was the first time I was facing this issue...

@ChristophWurst
Copy link
Member

One of us will have a look, no worries. If it's a bug there then we can create another ticket. For now I'd leave it here until my suspicion has been verified.

@Chartman123
Copy link
Author

Chartman123 commented May 9, 2022

I had a closer look at the code. I think that it is indeed a problem in the dialogs repo... The undo button will be added to the toast message there... Seems like the space reserved for the button stays in the size of the "Undo" text even if there is a longer text ("Rückgängig") so the toast message isn't correctly resized to the bigger button.

https://github.com/nextcloud/nextcloud-dialogs/blob/3ca4519d6763249238b82a9f6135c87f30c86937/styles/toast.scss#L38

https://github.com/nextcloud/nextcloud-dialogs/blob/3ca4519d6763249238b82a9f6135c87f30c86937/lib/toast.ts#L189-L194

@GretaD
Copy link
Contributor

GretaD commented May 9, 2022

I had a closer look at the code. I think that it is indeed a problem in the dialogs repo... The undo button will be added to the toast message there... Seems like the space reserved for the button stays in the size of the "Undo" text even if there is a longer text ("Rückgängig") so the toast message isn't correctly resized to the bigger button.

https://github.com/nextcloud/nextcloud-dialogs/blob/3ca4519d6763249238b82a9f6135c87f30c86937/styles/toast.scss#L38

https://github.com/nextcloud/nextcloud-dialogs/blob/3ca4519d6763249238b82a9f6135c87f30c86937/lib/toast.ts#L189-L194

thank you so much for investigating, i will fix this asap

@GretaD GretaD self-assigned this May 12, 2022
@GretaD GretaD moved this from 📄 To do (5-20 entries) to 🏗️ In progress in 💌 📅 👥 Groupware team May 12, 2022
Repository owner moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants