-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow pasting log entries #1040
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1040 +/- ##
==============================================
- Coverage 100.00% 44.42% -55.58%
- Complexity 0 168 +168
==============================================
Files 10 26 +16
Lines 168 700 +532
Branches 31 33 +2
==============================================
+ Hits 168 311 +143
- Misses 0 389 +389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d4abf37
to
9f7887a
Compare
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
@szaimen what do you mean with bugs? Or better: What did you do to end up with that state? |
I ended up in this state when I was testing the PR with my easy test instance which logs the log to stdout by default. If you now upload a log file or paste from clipboard, you can see the screenshots. |
instead of using keyboard events, you can use the |
Signed-off-by: Ferdinand Thiessen <[email protected]>
6f8f316
to
f961413
Compare
switched to the |
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
f961413
to
896731a
Compare
Before the Vue migration there was a hidden feature allowing you to paste on the logreader to show your clipboard content (log entries).
This is quite useful when e.g. having logs from GitHub issues.
So this PR brings back that function, to make it a bit more discoverable I added a info note to the settings modal:
And pasting looks like this, Firefox does not support Clipboard API so a fallback prompt is used:
vokoscreenNG-2023-11-11_01-07-11.mp4
Chromium / Chrome supports it, it just asks for confirmation / permissions and looks like this:
vokoscreenNG-2023-11-11_01-08-59.mp4