groupfolder 13.1.1 incompatible with NC 26.0.0beta3 and later

[nursoda]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

Steps to reproduce

1. Install NC26.0.0beta2
2. Install and activate groupfolders
3. Add some group folders
4. Add some folders, apply ACLs to them
5. Update to NC26.0.0beta3

Expected behaviour

groupfolders should be made compatible with NC > 26.0.0beta3

Actual behaviour

No cloud web start page, Error in nextcloud.log (see below)

Server configuration

Operating system: Arch Linux, php-legacy
Web server: NGINX
Database: MariaDB
PHP version: 8.1.5
Nextcloud version: 26.0.0.5
Group folders version: 13.1.1
Updated from an older Nextcloud/ownCloud or fresh install: Updated
Where did you install Nextcloud from: ZIP
Are you using external storage, if yes which one: local
Are you using encryption: no
Are you using an external user-backend, if yes which one: none

Client configuration

Browser: Firefox (irrelevant)
Operating system: Arch Linux (irrelevant)

Logs

Web server error log

Web server error log

(no entry)

Nextcloud log (data/nextcloud.log)

Nextcloud log

{
  "reqId": "Ztb8E8qzbdHzuLMuNhWq",
  "level": 3,
  "time": "2023-02-09T21:22:09+01:00",
  "remoteAddr": "192.168.1.2",
  "user": "USER",
  "app": "PHP",
  "method": "GET",
  "url": "/apps/files/",
  "message": "Declaration of OCA\\GroupFolders\\ACL\\ACLStorageWrapper::filesize($path) must be compatible with OC\\Files\\Storage\\Wrapper\\Wrapper::filesize($path): int|float|false at /FOLDER/apps/groupfolders/lib/ACL/ACLStorageWrapper.php#235",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0",
  "version": "26.0.0.5",
  "data": {
    "app": "PHP"
  }
}

Browser log

Browser log

(not relevant)

[nursoda]

I just verified, it also does fix the issue for me. After modifying the three files accordingly, and re-activating groupfolders, all works fine and I see no error messages in nextcloud.log. THANKS!

[nursoda]

In NC 26 beta4 I get errors again (and can no longer upload or change files):

{
  "reqId": "ax0OBYBJ1TXt0NiSOGwW",
  "level": 3,
  "time": "2023-02-21T23:08:22+01:00",
  "remoteAddr": "192.168.1.2",
  "user": "USER",
  "app": "PHP",
  "method": "PROPFIND",
  "url": "/remote.php/dav/files/USER/GROUPFOLDER",
  "message": "disk_free_space(): No such file or directory at /FOLDER/lib/private/Files/Storage/Local.php#421",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0",
  "version": "26.0.0.6",
  "data": {
    "app": "PHP"
  }
}
{
  "reqId": "6PhDmepj6XARTpYuqyU3",
  "level": 3,
  "time": "2023-02-21T23:08:25+01:00",
  "remoteAddr": "192.168.1.2",
  "user": "USER",
  "app": "PHP",
  "method": "PUT",
  "url": "/remote.php/webdav/GROUPFOLDER/FILENAME.pdf",
  "message": "disk_free_space(): No such file or directory at /FOLDER/lib/private/Files/Storage/Local.php#421",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0",
  "version": "26.0.0.6",
  "data": {
    "app": "PHP"
  }
}

[solracsf]

Test with https://github.com/nextcloud/groupfolders/releases/tag/v14.0.0

[nursoda]

At first glance it didn't look promising with GF 14.0.0. I tried to create a text file in a group folder that was created on NC26b1 with GF 13.1.1 installed. System today is NC 26.0.0.6 (beta 4).

1st attempt: creating a local file using the sync client:

nextcloud.log

{
  "reqId": "WlQ3UxVPbUJGW4hWgMUY",
  "level": 3,
  "time": "2023-02-23T18:18:45+01:00",
  "remoteAddr": "192.168.1.2",
  "user": "os",
  "app": "PHP",
  "method": "PUT",
  "url": "/remote.php/dav/files/USER/PATH/test.txt",
  "message": "disk_free_space(): No such file or directory at /FOLDER/lib/private/Files/Storage/Local.php#421",
  "userAgent": "Mozilla/5.0 (Linux) mirall/3.7.3git (Nextcloud, arch-6.1.12-arch1-1 ClientArchitecture: x86_64 OsArchitecture: x86_64)",
  "version": "26.0.0.6",
  "data": {
    "app": "PHP"
  }
}

2nd attempt was to create a test text file in the browser view:

nextcloud.log

{
  "reqId": "NoPhnwG5R8ytZaxGsQ1l",
  "level": 3,
  "time": "2023-02-23T18:20:54+01:00",
  "remoteAddr": "192.168.1.2",
  "user": "os",
  "app": "no app in context",
  "method": "POST",
  "url": "/ocs/v2.php/apps/files/api/v1/templates/create",
  "message": "Could not create path",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0",
  "version": "26.0.0.6",
  "exception": {
    "Exception": "OCP\\Files\\NotPermittedException",
    "Message": "Could not create path",
    "Code": 0,
    "Trace": [
      {
        "file": "/server/PATH/lib/private/Files/Template/TemplateManager.php",
        "line": 162,
        "function": "newFile",
        "class": "OC\\Files\\Node\\Folder",
        "type": "->"
      },
      {
        "file": "/server/PATH/apps/files/lib/Controller/TemplateController.php",
        "line": 57,
        "function": "createFromTemplate",
        "class": "OC\\Files\\Template\\TemplateManager",
        "type": "->"
      },
      {
        "file": "/server/PATH/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 230,
        "function": "create",
        "class": "OCA\\Files\\Controller\\TemplateController",
        "type": "->"
      },
      {
        "file": "/server/PATH/lib/private/AppFramework/Http/Dispatcher.php",
        "line": 137,
        "function": "executeController",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->"
      },
      {
        "file": "/server/PATH/lib/private/AppFramework/App.php",
        "line": 183,
        "function": "dispatch",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->"
      },
      {
        "file": "/server/PATH/lib/private/Route/Router.php",
        "line": 315,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::"
      },
      {
        "file": "/PATH/cloud/ocs/v1.php",
        "line": 63,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "/PATH/cloud/ocs/v2.php",
        "line": 23,
        "args": [
          "/PATH/cloud/ocs/v1.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/PATH/cloud/lib/private/Files/Node/Folder.php",
    "Line": 197,
    "message": "Could not create path",
    "exception": {},
    "CustomMessage": "Could not create path"
  }
}

Then it occurred to me that I probably should try with a group folder created on NC26 widh GF 14. I disabled, removed, installed (copy fron another instance since the app probably was withdrawn from apps.nextcloud.com. Nor all seems to work as expected,

I only get a LOOL-message on another issue:

nextcloud.log

{
  "reqId": "5cIOvKZ3im51uifhand2",
  "level": 4,
  "time": "2023-02-24T01:16:11+01:00",
  "remoteAddr": "78.94.68.74",
  "user": "--",
  "app": "core",
  "method": "POST",
  "url": "//lool/convert-to/png",
  "message": "",
  "userAgent": "Nextcloud Server Crawler",
  "version": "26.0.0.6",
  "exception": {
    "Exception": "Symfony\\Component\\Routing\\Exception\\MethodNotAllowedException",
    "Message": "",
    "Code": 0,
    "Trace": [
      {
        "file": "/FOLDER/cloud/lib/private/Route/Router.php",
        "line": 278,
        "function": "match",
        "class": "Symfony\\Component\\Routing\\Matcher\\UrlMatcher",
        "type": "->"
      },
      {
        "file": "/FOLDER/cloud/lib/private/Route/Router.php",
        "line": 307,
        "function": "findMatchingRoute",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "/FOLDER/cloud/lib/base.php",
        "line": 1098,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->"
      },
      {
        "file": "/FOLDER/cloud/index.php",
        "line": 36,
        "function": "handleRequest",
        "class": "OC",
        "type": "::"
      }
    ],
    "File": "/FOLDER/cloud/3rdparty/symfony/routing/Matcher/UrlMatcher.php",
    "Line": 96,
    "message": "",
    "exception": {},
    "CustomMessage": ""
  }
}